Skip to content

docs(self-managed): inventory optional ModelExpress artifacts in the manifest - #1355

Open
ankanand-nv wants to merge 1 commit into
NVIDIA:mainfrom
ankanand-nv:modelexpress-manifest
Open

docs(self-managed): inventory optional ModelExpress artifacts in the manifest#1355
ankanand-nv wants to merge 1 commit into
NVIDIA:mainfrom
ankanand-nv:modelexpress-manifest

Conversation

@ankanand-nv

@ankanand-nv ankanand-nv commented Aug 29, 2026

Copy link
Copy Markdown

TL;DR

Adds the ModelExpress chart and server image to the generated software inventory
as optional compute-plane add-ons.

Additional Details

Catalog entries only. No generator source or test changes, and
docs/user/image-mirroring.md is untouched.

Both entries use version: supported rather than an exact tag, matching the
seven existing entries in the catalog that do the same. ModelExpress installs
outside the compute-plane stack, so there is no pinned version for the manifest
to track. The tested combination, chart 0.5.1 with server 0.4.0, is recorded in
the guide and the sample instead, where a reader acting on it will see it.

For the Reviewer

The generated manifest.md here was produced by hand, because the generator
needs imports.yaml, which is absent from the public mirror by design. Please
treat CI's regenerated output as authoritative and flag any difference.

For QA

Manifest generation in CI.

Issues

Closes #1352

Checklist

  • I am familiar with the Contributing Guidelines.
  • I have signed off my commits for Developer Certificate of Origin (DCO) compliance.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

Summary by CodeRabbit

  • Documentation
    • Added optional Modelexpress Helm chart and server image entries to the compute-plane inventory.
    • Documented supported versions, distribution locations, descriptions, and upstream repository details.

…manifest

Signed-off-by: Ankit Anand <ankanand@nvidia.com>
@coderabbitai

coderabbitai Bot commented Aug 29, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 117b1bfb-4a59-43e7-bf9d-53bffdb4622b

📥 Commits

Reviewing files that changed from the base of the PR and between 9b2dd53 and f370813.

📒 Files selected for processing (2)
  • docs/user/manifest.md
  • docs/version-catalog/main.yaml

Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review.


📝 Walkthrough

Walkthrough

The version catalog and user manifest now list the optional ModelExpress Helm chart and server image as compute-plane artifacts. The entries include supported versions, distribution locations, descriptions, and upstream repositories.

Changes

ModelExpress artifact inventory

Layer / File(s) Summary
Catalog artifact declarations
docs/version-catalog/main.yaml
Adds optional modelexpress chart and modelexpress-server image entries with supported versions, distributions, descriptions, and upstream repositories.
Generated manifest entries
docs/user/manifest.md
Adds the optional ModelExpress chart and server image to the compute-plane inventory.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to f3708

This PR adds optional ModelExpress artifacts to the documentation inventory without changing runtime behavior, and no actionable merge-blocking risk remains after normal checks and review.

Suggested reviewers: pdmack

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title uses the valid Conventional Commits format docs(self-managed): subject and accurately describes the documentation-only inventory change.
Linked Issues check ✅ Passed The changes add the optional ModelExpress chart and server image to the compute-plane inventory. The catalog entries include supported versions, distribution locations, descriptions, and upstream repo…
Out of Scope Changes check ✅ Passed All changed files support the linked issue. The catalog and generated manifest updates are limited to the requested optional ModelExpress artifacts, with no unrelated source, test, or documentation ch…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Full details: Linked Issues check

Explanation

The changes add the optional ModelExpress chart and server image to the compute-plane inventory. The catalog entries include supported versions, distribution locations, descriptions, and upstream repository information. The changes also update the generated manifest and avoid generator, test, and image-mirroring documentation changes.

Full details: Out of Scope Changes check

Explanation

All changed files support the linked issue. The catalog and generated manifest updates are limited to the requested optional ModelExpress artifacts, with no unrelated source, test, or documentation changes.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@ankanand-nv
ankanand-nv marked this pull request as ready for review August 29, 2026 19:52
@ankanand-nv
ankanand-nv requested a review from a team as a code owner August 29, 2026 19:52
@ankanand-nv
ankanand-nv requested a review from pdmack August 29, 2026 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inventory optional ModelExpress artifacts in the software manifest

1 participant