docs(self-managed): inventory optional ModelExpress artifacts in the manifest - #1355
docs(self-managed): inventory optional ModelExpress artifacts in the manifest#1355ankanand-nv wants to merge 1 commit into
Conversation
…manifest Signed-off-by: Ankit Anand <ankanand@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review. 📝 WalkthroughWalkthroughThe version catalog and user manifest now list the optional ModelExpress Helm chart and server image as compute-plane artifacts. The entries include supported versions, distribution locations, descriptions, and upstream repositories. ChangesModelExpress artifact inventory
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This PR adds optional ModelExpress artifacts to the documentation inventory without changing runtime behavior, and no actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Linked Issues checkExplanation The changes add the optional ModelExpress chart and server image to the compute-plane inventory. The catalog entries include supported versions, distribution locations, descriptions, and upstream repository information. The changes also update the generated manifest and avoid generator, test, and image-mirroring documentation changes. Full details: Out of Scope Changes checkExplanation All changed files support the linked issue. The catalog and generated manifest updates are limited to the requested optional ModelExpress artifacts, with no unrelated source, test, or documentation changes. Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
TL;DR
Adds the ModelExpress chart and server image to the generated software inventory
as optional compute-plane add-ons.
Additional Details
Catalog entries only. No generator source or test changes, and
docs/user/image-mirroring.mdis untouched.Both entries use
version: supportedrather than an exact tag, matching theseven existing entries in the catalog that do the same. ModelExpress installs
outside the compute-plane stack, so there is no pinned version for the manifest
to track. The tested combination, chart 0.5.1 with server 0.4.0, is recorded in
the guide and the sample instead, where a reader acting on it will see it.
For the Reviewer
The generated
manifest.mdhere was produced by hand, because the generatorneeds
imports.yaml, which is absent from the public mirror by design. Pleasetreat CI's regenerated output as authoritative and flag any difference.
For QA
Manifest generation in CI.
Issues
Closes #1352
Checklist
Summary by CodeRabbit