feat(nvca): persist durable model cache storage decisions - #1357
Open
balajinvda wants to merge 1 commit into
Open
feat(nvca): persist durable model cache storage decisions#1357balajinvda wants to merge 1 commit into
balajinvda wants to merge 1 commit into
Conversation
Relates to #1326 Signed-off-by: balaji <balaji7@gmail.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Wire the storage capability catalog introduced by #1334 into NVCA model-cache request creation and runtime. New requests persist the exact
nvcf-scand catalog decision, create an immutableModelCacheBindingbefore storage side effects, and fail closed on drift or ownership mismatch.Additional Details
Why this is needed:
What changed:
nvcf-scprovisioner, requireRetain, and persist the selected catalog transition on each new model-cache request.ModelCacheBindingwith immutable provider, StorageClass, resource-intent, and request-UID state before starting regular or Helm cache work.ActivetoRetiringbefore destructive work. Concurrent users prevent retirement; the same request can resume interrupted cleanup.StorageRequest, PVC, Job, Secret, Lease holder, and reader PV/PVC generation.This PR is stacked on #1334. General zero-reference retirement and retained-data garbage collection remain follow-up work. Container cache and live-provider functional or performance qualification are outside this PR.
No third-party dependency changed. License review found no new violations, and
NOTICEdoes not change.For the Reviewer
Please focus on:
pkg/nvca;ActivetoRetiringrace handling and destructive cleanup guards;pkg/storage;StorageRequesthandoff and webhook read-only enforcement;The design and supported limitations are documented in
docs/dev/sdd-storage-agnostic-cache-architecture.md.For QA
QA is recommended for one NVMesh regular request and one NVMesh Helm request in a test cluster. Local validation completed:
go vetfor the same packages: pass;golangci-lintfor the impacted packages: 0 issues;./tools/ci/check-docswas not completed locally because the installed Fern CLI requires a newer Node runtime (cryptois unavailable under Node 18), and its advisory version-sync helper did not locate the repository root. Targeted checks for the changed design document passed.Issues
Relates to #1326
Checklist