[nri] only restrict management CDI devices to the toolkit namespace#1854
Open
tariq1890 wants to merge 1 commit into
Open
[nri] only restrict management CDI devices to the toolkit namespace#1854tariq1890 wants to merge 1 commit into
tariq1890 wants to merge 1 commit into
Conversation
Coverage Report for CI Build 26546901794Coverage decreased (-0.006%) to 43.49%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
When we had first implemented the NRI Plugin, we only expected it to be used to inject GPU management CDI devices. The current namespace check worked fine with that assumption. However, we have received requests to allow for the injection of CDI devices into gpu workload pods that don't need GPU management access. As this namespace check is not really required for workload pods, we update the namespace check to only apply to pods that explicitly request the GPU management CDI device. Signed-off-by: Tariq Ibrahim <tibrahim@nvidia.com>
tariq1890
force-pushed
the
revise-nri-namespace-check
branch
from
2803646 to
aa2b174
Compare
cdesiniotis
reviewed
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we had first implemented the NRI Plugin, we only expected it to be used to inject GPU management CDI devices. The current namespace check worked fine with that assumption. However, we have received requests to allow for the injection of CDI devices into gpu workload pods that don't need GPU management access. As this namespace check is not really required for workload pods, we update the namespace check to only apply to pods that explicitly request the GPU management CDI device.