Don't run post_install_test by default - #23
Open
zjohl wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm attempting to upgrade to ruby 4 in one of my apps that uses dhash-vips. I ended up seeing an error from this gem:
extconf.rbprepends atest:alltarget to the Makefile, which makestestthe default make target. This was causing issues in the parallel install of our dependency image becauseffiwasn't resolvable whendhash-vipsbuilt, somake testfailed and aborted the install.My fix for this was switching to append this target to the makefile, and renaming it, so it's not the default and won't be run on bundle install. I also updated the README to use
make post_install_testinstead of justmake