Fix #230 - Address v26.2.0 failures - #231
Open
jmarrec wants to merge 2 commits into
Open
Conversation
… schedule is not assigned. #230 (comment)
All 9 tests (`air_chillers`, `airloop_and_zonehvac`, `zone_hvac2` × osm/py/rb) pass on the `3.12.0-alpha` (IOFreeze) build — 0 failures, 0 errors, 0 skips, and `total_site_energy` is **bit-identical to 3.11.0** across the board (0.0000% diff on all nine). So the humidistat fix resolves the fatal sizing error without changing any simulation results — the dehumidifier's energy impact was already negligible/unaffected in these models, as expected since the fix just gives it a schedule to look at, not different setpoints that would change equipment operation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #230 (comment)
So far:
Missing ZoneControl:Humidistat (Fatal) — same root cause as air_chillers
The ZoneControl:Humidistat was missing because it didn't have any schedules. E+ enforces the presence of the ZoneControl:Humidistat. The Humidfying schedule is required per E+ IDD. So we don't have any diffs in EUI, I'm assigning a Hum Schedule = 0% and a Dehum Schedule = 100%. There's no hum/dehum happening at all, but the test runs.
d3e7e55 should pass with 3.11.0 without any diffs (confirmed locally). And it does run with develop at 26.2.0-IOFreeze