V26.2.0-IOFreeze: new Absorptance Inside Face fields - #5648
Open
joseph-robertson wants to merge 8 commits into
Open
V26.2.0-IOFreeze: new Absorptance Inside Face fields#5648joseph-robertson wants to merge 8 commits into
joseph-robertson wants to merge 8 commits into
Conversation
Contributor
🧪 Test Results DashboardSummary
❌ Significant Test Failures📊 Test Run Information
|
There was a problem hiding this comment.
🟡 Changes recommended
The blank Material:NoMass reverse-translation test uses incorrect field indices, invalidating its fallback assertions.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds inside-face absorptance support for standard and massless opaque materials, including blank-value inheritance and EnergyPlus translation.
Changes:
- Extends the model schema and APIs with three inside-face absorptance fields.
- Adds forward and reverse translation support.
- Adds model and translator tests.
File summaries
| File | Description |
|---|---|
resources/model/OpenStudio.idd |
Defines the optional fields. |
src/model/StandardOpaqueMaterial.hpp |
Exposes the standard-material API. |
src/model/StandardOpaqueMaterial_Impl.hpp |
Declares implementation methods. |
src/model/StandardOpaqueMaterial.cpp |
Implements fallback and mutation behavior. |
src/model/MasslessOpaqueMaterial.hpp |
Exposes the massless-material API. |
src/model/MasslessOpaqueMaterial_Impl.hpp |
Declares implementation methods. |
src/model/MasslessOpaqueMaterial.cpp |
Implements fallback and mutation behavior. |
src/model/test/StandardOpaqueMaterial_GTest.cpp |
Tests standard-material behavior. |
src/model/test/MasslessOpaqueMaterial_GTest.cpp |
Tests massless-material behavior. |
src/energyplus/ForwardTranslator/ForwardTranslateStandardOpaqueMaterial.cpp |
Writes explicit standard-material values. |
src/energyplus/ForwardTranslator/ForwardTranslateMasslessOpaqueMaterial.cpp |
Writes explicit massless-material values. |
src/energyplus/ReverseTranslator/ReverseTranslateMaterial.cpp |
Imports standard-material values. |
src/energyplus/ReverseTranslator/ReverseTranslateMaterialNoMass.cpp |
Imports massless-material values. |
src/energyplus/Test/ForwardTranslator_GTest.cpp |
Tests omission and emission behavior. |
src/energyplus/Test/ReverseTranslator_GTest.cpp |
Tests imports and blank-field fallback. |
Review details
- Files reviewed: 15/15 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request overview
Pull Request Author
src/model/test)src/energyplus/Test)src/osversion/VersionTranslator.cpp)Labels:
IDDChangeAPIChangePull Request - Ready for CIso that CI builds your PRReview Checklist
This will not be exhaustively relevant to every PR.