Skip to content

V26.2.0-IOFreeze: new Absorptance Inside Face fields - #5648

Open
joseph-robertson wants to merge 8 commits into
developfrom
v26.2.0-IOFreeze-InsideFaceAbs
Open

V26.2.0-IOFreeze: new Absorptance Inside Face fields#5648
joseph-robertson wants to merge 8 commits into
developfrom
v26.2.0-IOFreeze-InsideFaceAbs

Conversation

@joseph-robertson

Copy link
Copy Markdown
Collaborator

Pull request overview

  • Fixes #ISSUENUMBERHERE (IF THIS IS A DEFECT)

Pull Request Author

  • Model API Changes / Additions
  • Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
  • Model API methods are tested (in src/model/test)
  • EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
  • If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
  • If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
  • Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
  • All new and existing tests passes
  • If methods have been deprecated, update rest of code to use the new methods

Labels:

  • If change to an IDD file, add the label IDDChange
  • If breaking existing API, add the label APIChange
  • If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • Code Style, strip trailing whitespace, etc.
  • All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
  • Labeling is ok
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified

@joseph-robertson joseph-robertson self-assigned this Sep 1, 2026
@joseph-robertson joseph-robertson added Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. IDDChange labels Sep 1, 2026
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

🧪 Test Results Dashboard

Summary

Metric Value
Total Tests 0
Passed 0
Failed 0
Errors 0
Skipped 0
Success Rate 0.0%
Generated 2026-09-01 22:20:05 UTC

❌ Significant Test Failures

📊 Test Run Information

Run XML File Status
- No XML files found ❌ Missing

@joseph-robertson
joseph-robertson requested a balanced review from Copilot September 1, 2026 21:47
@joseph-robertson
joseph-robertson marked this pull request as ready for review September 1, 2026 21:47

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The blank Material:NoMass reverse-translation test uses incorrect field indices, invalidating its fallback assertions.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Adds inside-face absorptance support for standard and massless opaque materials, including blank-value inheritance and EnergyPlus translation.

Changes:

  • Extends the model schema and APIs with three inside-face absorptance fields.
  • Adds forward and reverse translation support.
  • Adds model and translator tests.
File summaries
File Description
resources/model/OpenStudio.idd Defines the optional fields.
src/model/StandardOpaqueMaterial.hpp Exposes the standard-material API.
src/model/StandardOpaqueMaterial_Impl.hpp Declares implementation methods.
src/model/StandardOpaqueMaterial.cpp Implements fallback and mutation behavior.
src/model/MasslessOpaqueMaterial.hpp Exposes the massless-material API.
src/model/MasslessOpaqueMaterial_Impl.hpp Declares implementation methods.
src/model/MasslessOpaqueMaterial.cpp Implements fallback and mutation behavior.
src/model/test/StandardOpaqueMaterial_GTest.cpp Tests standard-material behavior.
src/model/test/MasslessOpaqueMaterial_GTest.cpp Tests massless-material behavior.
src/energyplus/ForwardTranslator/ForwardTranslateStandardOpaqueMaterial.cpp Writes explicit standard-material values.
src/energyplus/ForwardTranslator/ForwardTranslateMasslessOpaqueMaterial.cpp Writes explicit massless-material values.
src/energyplus/ReverseTranslator/ReverseTranslateMaterial.cpp Imports standard-material values.
src/energyplus/ReverseTranslator/ReverseTranslateMaterialNoMass.cpp Imports massless-material values.
src/energyplus/Test/ForwardTranslator_GTest.cpp Tests omission and emission behavior.
src/energyplus/Test/ReverseTranslator_GTest.cpp Tests imports and blank-field fallback.
Review details
  • Files reviewed: 15/15 changed files
  • Comments generated: 1
  • Review effort level: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/energyplus/Test/ReverseTranslator_GTest.cpp Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

IDDChange Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants