fix: worker HPA replicas ownership + parameterized rollout strategy - #121
Open
anchapin wants to merge 1 commit into
Open
fix: worker HPA replicas ownership + parameterized rollout strategy#121anchapin wants to merge 1 commit into
anchapin wants to merge 1 commit into
Conversation
- worker deployment: remove hardcoded spec.replicas so the HPA owns scaling across helm upgrades. Helm's three-way merge preserves fields absent from the manifest; a hardcoded value would reset the deployment to 1 replica on every upgrade (scale-to-1 cliff at high maxReplicas). - worker rollout strategy: parameterize maxSurge/maxUnavailable with defaults replicating the previous hardcoded 1/1 behavior. - PriorityClasses: render unconditionally instead of guarding on a cluster lookup. When the class already existed, the guard omitted it from the manifest, causing helm upgrade to delete the cluster-scoped PriorityClass out from under running pods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
spec.replicas: 1— the HPA owns scaling across helm upgrades (prevents the scale-to-1 cliff where everyhelm upgradereset the deployment to 1 replica whilemaxReplicaswas in the thousands).maxSurge/maxUnavailableparameterized; defaults replicate prior hardcoded 1/1.lookupguard omitted already-existing classes from the manifest, sohelm upgradedeleted the cluster-scoped PriorityClass out from under running pods.Verification
helm templaterenders all three value variants; live-cluster upgrade path exercised by the stacked PR branch.