Expanding language keys and adding mixed-language speech.#5271
Open
MistakeNot4892 wants to merge 1 commit into
Open
Expanding language keys and adding mixed-language speech.#5271MistakeNot4892 wants to merge 1 commit into
MistakeNot4892 wants to merge 1 commit into
Conversation
6ea8321 to
1c17b68
Compare
out-of-phaze
previously requested changes
Jan 14, 2026
1fe1556 to
3b090d3
Compare
Contributor
Author
|
I need to do some more exhaustive testing before merge, but I think this is good for review now. |
ce8b024 to
f63c163
Compare
72f4a9f to
7df06a5
Compare
Contributor
Author
|
Binary radio headset does allow you to send different languages over binary, but that is a niche enough case that I don't want to fix it for this PR. |
c919795 to
2d92651
Compare
Rewriting/organising holopad code. Debugging/further work on mixed language speech.
2d92651 to
b86ff09
Compare
Contributor
Author
|
Last issue is that overhead text flickers and is out of place for 1 tick immediately after creation. I have no idea why, logic looks straightforward. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This was just supposed to be the keys stuff but I kinda spiralled.
,1is your first known language.,hwill match,human.Why and what will this PR improve
Mixing languages in speech is good fun for RP, and the backend changes have cleaned up, centralized a fair wodge of logic.
TODO
Issues
Animal noises are not scrambled.Type understands type, intentional.Authorship
Myself.
Changelog
TBD