Skip to content

bugfix/CSTACKEX-169: Fix enum case sensitive issues #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
piyush5netapp wants to merge 1 commit into
base: main
Choose a base branch
from
+16 −3
Open

bugfix/CSTACKEX-169: Fix enum case sensitive issues #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ...rage/volume/ontap/src/main/java/org/apache/cloudstack/storage/feign/model/ExportRule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,11 @@

package org.apache.cloudstack.storage.feign.model;

import com.fasterxml.jackson.annotation.JsonCreator;
import com.fasterxml.jackson.annotation.JsonIgnoreProperties;
import com.fasterxml.jackson.annotation.JsonInclude;
import com.fasterxml.jackson.annotation.JsonProperty;
import com.fasterxml.jackson.annotation.JsonValue;
import java.util.List;

/**
Expand Down Expand Up @@ -54,6 +56,7 @@ public enum ProtocolsEnum {
this.value = value;
}

@JsonValue
public String getValue() {
return value;
}
Expand All @@ -63,9 +66,11 @@ public String toString() {
return String.valueOf(value);
}

@JsonCreator
public static ProtocolsEnum fromValue(String text) {
if (text == null) return null;
for (ProtocolsEnum b : ProtocolsEnum.values()) {
if (String.valueOf(b.value).equals(text)) {
if (b.value.equalsIgnoreCase(text)) {
Copy link
Copy Markdown

@suryag1201 suryag1201 Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would cause NPE if b.value is null.
Add null check for b.value or add a opposite condition like text.equalsIgnoreCase(b.value)

return b;
}
}
Expand Down
12 changes: 10 additions & 2 deletions .../storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/feign/model/Igroup.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,11 @@

package org.apache.cloudstack.storage.feign.model;

import com.fasterxml.jackson.annotation.JsonCreator;
import com.fasterxml.jackson.annotation.JsonIgnoreProperties;
import com.fasterxml.jackson.annotation.JsonInclude;
import com.fasterxml.jackson.annotation.JsonProperty;
import com.fasterxml.jackson.annotation.JsonValue;

import java.util.List;
import java.util.Objects;
Expand Down Expand Up @@ -71,6 +73,7 @@ public enum OsTypeEnum {
this.value = value;
}

@JsonValue
public String getValue() {
return value;
}
Expand All @@ -80,9 +83,11 @@ public String toString() {
return String.valueOf(value);
}

@JsonCreator
public static OsTypeEnum fromValue(String text) {
if (text == null) return null;
for (OsTypeEnum b : OsTypeEnum.values()) {
if (String.valueOf(b.value).equals(text)) {
if (b.value.equalsIgnoreCase(text)) {
Copy link
Copy Markdown

@suryag1201 suryag1201 Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would cause NPE if b.value is null.
Add null check for b.value or add a opposite condition like text.equalsIgnoreCase(b.value)

return b;
}
}
Expand Down Expand Up @@ -122,6 +127,7 @@ public enum ProtocolEnum {
this.value = value;
}

@JsonValue
public String getValue() {
return value;
}
Expand All @@ -131,9 +137,11 @@ public String toString() {
return String.valueOf(value);
}

@JsonCreator
public static ProtocolEnum fromValue(String text) {
if (text == null) return null;
for (ProtocolEnum b : ProtocolEnum.values()) {
if (String.valueOf(b.value).equals(text)) {
if (b.value.equalsIgnoreCase(text)) {
Copy link
Copy Markdown

@suryag1201 suryag1201 Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

return b;
}
}
Expand Down
Loading