Add end-to-end integration tests for deposit#243
Merged
Conversation
Neurowealth#219 Add end-to-end integration tests for deposit and withdraw flows Repo Avatar Neurowealth/Backend Summary Deposit and withdraw are the most financially sensitive flows but only have unit-level coverage. Full integration tests against a real Postgres + mocked Stellar RPC would catch regressions that unit tests miss. Scope Seed test database with a funded user and custodial wallet POST /api/deposit: verify Transaction record, position update, event cursor advance POST /api/withdraw: verify balance deduction, transaction record, DLQ on RPC failure Assert correct HTTP status, response shape, and database state after each operation Acceptance Criteria Tests run against a Dockerised Postgres (can use existing docker-compose) Stellar RPC calls are mocked via jest.mock Both happy path and error path (RPC failure → DLQ) covered Tests added to CI node-ci.yml workflow
|
@DeveloperEmmy Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
DeveloperEmmy
changed the title
DeveloperEmmy
changed the title
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #219