vignettes: tighten prose, drop redundant figures, fold tmax/tmin + annual snow into faceted panels#75
Merged
Merged
Conversation
…nual snow signals into faceted panels Both regional vignettes (kootenay-lake, peace-fwcp) get parallel treatment: Plain-language reworks - "Snowpack is the hinge of BC hydrology" -> mechanism-first opener: "In BC, most of the year's runoff starts as winter snow. The snowpack stores it, then releases it as meltwater across spring and summer." - Trends section preamble: define "anomaly" up front, name the two trend windows in plain English, drop the redundant sentence about "slower never means stopped". - Recent Decade vs Pre-Warming preamble: tighten the two-p-value explanation to one paragraph; split intro vs p-value discussion for readability. - Daytime Highs preamble: drop "three figures below" lead-in (now one figure). - Snow background bias notes: 4 paragraphs of methods -> 1 paragraph that says the model misses absolute mm but trends are credible. - Annual snowpack signals intro: replace the 4-metric literature scaffolding with a 3-bullet plain-language list (Peak SWE, DOY-50, snowfall fraction). - Interpretation closer (salmonid framing): single tightened paragraph leading with the citations, then three bold knock-on effects. Figure cuts and amalgamations - Cut plot-tmean (annual mean line) - per-ecoregion facet covers it. - Combine plot-tmax + plot-tmin into one 2-panel faceted plot-tmaxmin chunk. - Cut plot-dtr (diurnal range) - asymmetry numbers already in prose. - Cut snow-rate-peak (freshet flashiness) - not load-bearing in narrative. - Combine snow-swe-max + snow-doy-50 + snow-fraction into one 3-panel faceted snow-annual chunk with scales="free_y". Bibliography - Drop kouki_etal2023Evaluationsnow (Northern-Hemisphere cell-mean bias background, no longer cited) - Drop yue_wang2002Applicabilityprewhitening (Mann-Kendall pre-whitening methods note, no longer cited) - 17 -> 15 entries; bib union matches used keys exactly. Verification - Both vignettes render cleanly via rmarkdown::render() with devtools::load_all(). - New faceted figures inspected visually: strip titles, axis labels (incl. degree symbol), legend, and free y-scales all read clean. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tighten both regional vignettes (kootenay-lake, peace-fwcp) in parallel: plainer language for new readers, fewer redundant figures, tighter prose.
Plain-language reworks
Figure cuts and amalgamations
plot-tmean— the per-ecoregionfacet-tmeancovers it.plot-tmax+plot-tmin→ one 2-panel facetedplot-tmaxminchunk.plot-dtr— asymmetry numbers already in prose.snow-rate-peak— not load-bearing in narrative.snow-swe-max+snow-doy-50+snow-fraction→ one 3-panel facetedsnow-annualchunk withscales = "free_y".Net change per vignette: −5 standalone figure chunks, +2 faceted chunks → 3 fewer figures, same coverage.
Bibliography
kouki_etal2023Evaluationsnow(Northern-Hemisphere cell-mean bias background, no longer cited).yue_wang2002Applicabilityprewhitening(Mann-Kendall pre-whitening methods note, no longer cited).Test plan
knitr::purl()+parse().rmarkdown::render()withdevtools::load_all().🤖 Generated with Claude Code