Skip to content

vignettes: tighten prose, drop redundant figures, fold tmax/tmin + annual snow into faceted panels#75

Merged
NewGraphEnvironment merged 1 commit into
mainfrom
vignette-tighten
Jun 6, 2026
Merged

vignettes: tighten prose, drop redundant figures, fold tmax/tmin + annual snow into faceted panels#75
NewGraphEnvironment merged 1 commit into
mainfrom
vignette-tighten

Conversation

@NewGraphEnvironment

Copy link
Copy Markdown
Owner

Summary

Tighten both regional vignettes (kootenay-lake, peace-fwcp) in parallel: plainer language for new readers, fewer redundant figures, tighter prose.

Plain-language reworks

  • "Snowpack is the hinge of BC hydrology" → mechanism-first opener: "In BC, most of the year's runoff starts as winter snow. The snowpack stores it, then releases it as meltwater across spring and summer."
  • Trends section preamble: define "anomaly" up front, name the two trend windows in plain English.
  • Recent Decade vs Pre-Warming preamble: two-p-value explanation tightened; intro and p-value discussion split for readability.
  • Daytime Highs preamble: drop "three figures below" lead-in (now one figure).
  • Snow background bias notes: 4 paragraphs of methods → 1 paragraph that says the model misses absolute mm but trends are credible.
  • Annual snowpack signals intro: 4-metric literature scaffolding → 3-bullet plain-language list (Peak SWE, DOY-50, snowfall fraction).
  • Interpretation closer (salmonid framing): single tightened paragraph leading with the citations, then three bold knock-on effects.

Figure cuts and amalgamations

  • Cut plot-tmean — the per-ecoregion facet-tmean covers it.
  • Combine plot-tmax + plot-tmin → one 2-panel faceted plot-tmaxmin chunk.
  • Cut plot-dtr — asymmetry numbers already in prose.
  • Cut snow-rate-peak — not load-bearing in narrative.
  • Combine snow-swe-max + snow-doy-50 + snow-fraction → one 3-panel faceted snow-annual chunk with scales = "free_y".

Net change per vignette: −5 standalone figure chunks, +2 faceted chunks → 3 fewer figures, same coverage.

Bibliography

  • Drop kouki_etal2023Evaluationsnow (Northern-Hemisphere cell-mean bias background, no longer cited).
  • Drop yue_wang2002Applicabilityprewhitening (Mann-Kendall pre-whitening methods note, no longer cited).
  • 17 → 15 entries; bib union matches used keys exactly.

Test plan

  • Both vignettes parse via knitr::purl() + parse().
  • Both vignettes render cleanly via rmarkdown::render() with devtools::load_all().
  • New faceted figures inspected visually: strip titles, axis labels (incl. ° degree symbol), legend ("Trend window — 1951-2025 / 1981-2025"), and free y-scales all read clean.
  • Bib union matches used citation keys exactly (15/15).
  • pkgdown CI builds clean on merge.

🤖 Generated with Claude Code

…nual snow signals into faceted panels

Both regional vignettes (kootenay-lake, peace-fwcp) get parallel treatment:

Plain-language reworks
- "Snowpack is the hinge of BC hydrology" -> mechanism-first opener: "In BC, most of the year's runoff starts as winter snow. The snowpack stores it, then releases it as meltwater across spring and summer."
- Trends section preamble: define "anomaly" up front, name the two trend windows in plain English, drop the redundant sentence about "slower never means stopped".
- Recent Decade vs Pre-Warming preamble: tighten the two-p-value explanation to one paragraph; split intro vs p-value discussion for readability.
- Daytime Highs preamble: drop "three figures below" lead-in (now one figure).
- Snow background bias notes: 4 paragraphs of methods -> 1 paragraph that says the model misses absolute mm but trends are credible.
- Annual snowpack signals intro: replace the 4-metric literature scaffolding with a 3-bullet plain-language list (Peak SWE, DOY-50, snowfall fraction).
- Interpretation closer (salmonid framing): single tightened paragraph leading with the citations, then three bold knock-on effects.

Figure cuts and amalgamations
- Cut plot-tmean (annual mean line) - per-ecoregion facet covers it.
- Combine plot-tmax + plot-tmin into one 2-panel faceted plot-tmaxmin chunk.
- Cut plot-dtr (diurnal range) - asymmetry numbers already in prose.
- Cut snow-rate-peak (freshet flashiness) - not load-bearing in narrative.
- Combine snow-swe-max + snow-doy-50 + snow-fraction into one 3-panel faceted snow-annual chunk with scales="free_y".

Bibliography
- Drop kouki_etal2023Evaluationsnow (Northern-Hemisphere cell-mean bias background, no longer cited)
- Drop yue_wang2002Applicabilityprewhitening (Mann-Kendall pre-whitening methods note, no longer cited)
- 17 -> 15 entries; bib union matches used keys exactly.

Verification
- Both vignettes render cleanly via rmarkdown::render() with devtools::load_all().
- New faceted figures inspected visually: strip titles, axis labels (incl. degree symbol), legend, and free y-scales all read clean.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@NewGraphEnvironment NewGraphEnvironment merged commit a2d64a0 into main Jun 6, 2026
1 check passed
@NewGraphEnvironment NewGraphEnvironment deleted the vignette-tighten branch June 6, 2026 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant