merging master into experiimental - #351
Open
dellams wants to merge 1091 commits into
Open
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| npx hardhat run scripts/deploy.js --network optimism | ||
| # ... etc for each chain | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Documentation references non-existent script directory paths
High Severity
The deployment documentation instructs users to run commands like node scripts/deploy-evm-chain.js and cp scripts/hardhat.config.template.js hardhat.config.js, but these scripts are actually located at Scripts/Smart Contracts/, not scripts/. Every command users run following the documentation will fail with "file not found" errors. The deployment scripts exist but at the wrong path documented.
Additional Locations (2)
| npm run deploy:all:testnet | ||
| npm run deploy:aptos:testnet | ||
| npm run deploy:sui:mainnet | ||
| # ... see package.json for all scripts |
There was a problem hiding this comment.
Missing npm scripts referenced in documentation
High Severity
The documentation claims users can run npm scripts like npm run check-status, npm run deploy:ethereum:testnet, and npm run deploy:all:testnet, but the root package.json contains no scripts section at all—only a devDependency for mermaid-cli. Users attempting to run these documented commands will get "missing script" errors.
Additional Locations (1)
| 3. **Checklist**: `DEPLOYMENT_CHECKLIST.md` - Step-by-step checklist | ||
| 4. **Status**: `DEPLOYMENT_STATUS.md` - Current deployment status | ||
| 5. **Scripts**: `scripts/README.md` - Scripts documentation | ||
| 6. **Summary**: `scripts/DEPLOYMENT_AUTOMATION_SUMMARY.md` - Automation overview |
There was a problem hiding this comment.
Documentation index references non-existent files
Medium Severity
The documentation index references scripts/QUICK_START.md and scripts/README.md as available documentation files, but these files don't exist at the specified paths. Users looking for the Quick Start guide or Scripts documentation will encounter broken references.
Additional Locations (1)
| shell: pwsh | ||
| run: | | ||
| & "OASIS Omniverse/STARAPIClient/run_star_api_test_suite.ps1" -Configuration Release -KillStaleTestHosts $true | ||
|
|
There was a problem hiding this comment.
STARAPIClient tests likely fail on Ubuntu
High Severity
The new test-starapi-client job runs run_star_api_test_suite.ps1 on ubuntu-latest via pwsh, but related STARAPIClient scripts in the same area use Windows-only tooling/paths (e.g., C:\..., MSVC). If run_star_api_test_suite.ps1 has similar assumptions, the workflow will fail and block build-and-package via needs.
Additional Locations (1)
| STAR ODK/NextGenSoftware.OASIS.STAR.CLI/publish/linux-arm64/DNA/Default/OASIS_DNA.json | ||
| STAR ODK/NextGenSoftware.OASIS.STAR.CLI/publish/linux-arm64/DNA/CelestialBodyDNA.json | ||
| STAR ODK/NextGenSoftware.OASIS.STAR.CLI/publish/linux-arm64/Cosmos.CRTCompat.dll | ||
| STAR ODK/NextGenSoftware.OASIS.STAR.CLI/publish/installers/star-cli-3.4.0-win-x64.exe |
There was a problem hiding this comment.
Entire publish gitignore block duplicated from merge
Low Severity
The entire block of publish directory entries (lines 315–877) is exactly duplicated at lines 878–1440, adding ~560 redundant lines from what appears to be a merge artifact. Additionally, most entries under publish/ subdirectories are already covered by the existing publish/ pattern on line 139, making them doubly unnecessary. Only the publishwin-x64/ entries aren't covered by the existing pattern.
Additional Locations (1)
railway-app
Bot
temporarily deployed
to
invigorating-recreation / production
February 26, 2026 05:10
Inactive
railway-app
Bot
temporarily deployed
to
invigorating-recreation / production
February 27, 2026 06:43
Inactive
railway-app
Bot
temporarily deployed
to
invigorating-recreation / production
February 27, 2026 08:12
Inactive
railway-app
Bot
temporarily deployed
to
invigorating-recreation / production
February 27, 2026 19:04
Inactive
railway-app
Bot
temporarily deployed
to
invigorating-recreation / production
February 27, 2026 19:11
Inactive
railway-app
Bot
temporarily deployed
to
invigorating-recreation / production
February 27, 2026 20:29
Inactive
railway-app
Bot
temporarily deployed
to
invigorating-recreation / production
February 27, 2026 20:31
Inactive
railway-app
Bot
temporarily deployed
to
invigorating-recreation / production
February 27, 2026 20:31
Inactive
railway-app
Bot
temporarily deployed
to
invigorating-recreation / production
February 27, 2026 21:04
Inactive
…of hardcoding false
- New ArweaveOASIS provider (partial class split across 4 files) implementing IOASISStorageProvider and IOASISNETProvider, mirroring PinataOASIS structure - ArweaveService: RSA-PSS signed transaction posting, GraphQL tag-based queries, data retrieval via Arweave gateway; read-only if no wallet configured - Connection string format: wallet=/path/to/wallet.json&gateway=https://arweave.net - Delete operations write tombstone transactions (Arweave data is permanent) - Added NFTOffChainMetaType.Arweave enum value - Added ArweaveOASISSettings to OASISDNA.Storage.cs and StorageProviderSettings - Registered in OASISBootLoader with ArweaveOASIS_StorageProviderError handler - Added Arweave property to NFTManager (lazy-activated, same pattern as Pinata/IPFS) - NFTManager.Wallets2.cs: Arweave cases in both NFT image and JSON metadata switches - OASIS_DNA.json: ArweaveOASIS config block with empty ConnectionString - STAR CLI NFTCommon.Generate.cs: updated prompt text to include Arweave option
…CP tool description
Replaces the misleading AGPL-3.0 LICENSE file with a custom source-available HoloSource License 1.0 that accurately reflects the project's intent: free for personal/educational/internal use, commercial license required for SaaS/hosted/public products. Updates README badge and license section to match.
Replaces the misleading AGPL-3.0 LICENSE file with a custom source-available HoloSource License 1.0 that accurately reflects the project's intent: free for personal/educational/internal use, commercial license required for SaaS/hosted/public products. Updates README badge and license section to match.
… Arweave, fix TONSOASIS typo, add 25 missing providers to swagger and web4 site
…l ProjectReference/PackageReference applied to 100 provider projects
…Get publish workflow
…graph - Pure GraphQL over https://api.lens.xyz/graphql (no external NuGet deps) - LoadAvatarByUsernameAsync: profile by Lens handle (lens/stani) - LoadAvatarByProviderKeyAsync: default profile by owner EVM address - LoadAllAvatarsAsync: top Lens profiles by followers via exploreProfiles - LoadHolonAsync(providerKey): load publication by Lens publication ID - LoadAllHolonsAsync: explore trending posts via explorePublications - LoadHolonsForParentAsync(profileId): all posts for a given profile - SearchAsync: search profiles by keyword via searchProfiles query - CreatePostAsync: post creation with onchain mutation (requires JWT access token) - SaveAvatar/SaveHolon/Delete: return informative error (EVM wallet signature required) - LensOASIS added to ProviderType enum in API.Core submodule - Project added to The OASIS Minimal.sln
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Moderate risk because it changes CI orchestration by adding a new
test-starapi-clientjob and making release builds depend on it; failures or environment assumptions in the PowerShell test suite could block packaging. Other changes are documentation and.gitignorehygiene with minimal runtime impact.Overview
CI now runs the STARAPIClient automated suite by adding a new
test-starapi-clientjob that executesOASIS Omniverse/STARAPIClient/run_star_api_test_suite.ps1, uploadsTestResults/artifacts, and is required forbuild-and-package.Repo hygiene and docs were expanded:
.gitignorenow excludes common deployment secrets/config (e.g..env,hardhat.config.js,deployed-addresses.json,*.key/*.pem) and STAR CLI publish/install artifacts; a staleDockerfile.star-api.newwas removed; and multiple newDocs/Devs/*guides were added/linked covering smart-contract deployment and cross-platform getting-started/installer workflows.Written by Cursor Bugbot for commit d69b90f. This will update automatically on new commits. Configure here.