Daily review 2026-06-24 - #59
Draft
NghaReformer wants to merge 1 commit into
Draft
Conversation
Automated daily audit: 3 hardcoded-color violations found (CategoryBreakdownDonut hex palette, EntryHistory #fff, KpiStrip --orange fallback). All Svelte 5 runes, i18n, server-boundary, and a11y checks passed clean. Five new playground proposals added (TVA, Payroll, Inventory, Ratio Analyser, Cash Flow Builder).
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Daily Review — 2026-06-24
Automated codebase audit. Full report at
reports/daily/2026-06-24.md.1. Bugs & Issues
HIGH
1.1 Hardcoded hex colors in
CategoryBreakdownDonut.svelteFile:
src/lib/playgrounds/bank-reconciliation/components/CategoryBreakdownDonut.svelte:31–39Nine hex literals are defined in a
CATEGORY_COLORSconstant and injected into the DOMvia
style="background: {seg.color}"(line 120) and as an SVGstrokeattribute (line 94).This bypasses the design system entirely — if the theme palette changes, the donut chart
will silently diverge.
Suggested fix: Add nine
--chart-cat-*tokens tosrc/lib/theme/tokens.ts, generateCSS vars via the existing
css-generator.tspipeline, and replace the hex literals withvar(--chart-cat-*)strings.MEDIUM
1.2 Hardcoded
#fffinEntryHistory.svelteFile:
src/lib/playgrounds/journal-entry/components/EntryHistory.svelte:400color: #fff;— white hardcoded in CSS instead of a theme token.Suggested fix: Replace with
var(--text-on-accent)orvar(--bg)depending on theelement's background context.
1.3 Unknown
--orangetoken with hardcoded hex fallback inKpiStrip.svelteFile:
src/lib/components/playground/KpiStrip.svelte:76color: var(--orange, #f59e0b)—--orangeis not declared intokens.ts. The themedefines
--amber(#f5a623). The hex fallback always activates.Suggested fix: Replace with
var(--amber), or addorangetotokens.ts.LOW
1.4
anytype on dynamic component loadersFile:
src/lib/contracts/playground.ts:69–72Suppressed
@typescript-eslint/no-explicit-anyonComponent<any>dynamic imports.Acceptable for now; revisit when Svelte stabilises
ComponentType.2. Checks Passed Clean
style=usage3. New Playground Ideas
3.1 VAT / TVA Calculator — Simulateur de TVA
Target: Licence 2–3 | Fixes confusion between TVA collectée vs TVA déductible and
net position (à décaisser / crédit reporté). Exposes OHADA-zone rate differences
(17.5–20 %).
3.2 Payroll Builder — Simulateur de bulletin de paie
Target: Licence 3 / professional | Gross → cotisations sociales → IRPP → net, with
country profiles (CNPS-CI, CNSS-CM, IPRES-SN). Goal-seek from desired net to gross.
3.3 Inventory Valuation — Évaluation des stocks
Target: Licence 2 | FIFO / CUMP / LIFO comparison; shows profit and COGS impact of
method choice. LIFO included comparatively (prohibited under SYSCOHADA but tested).
3.4 Financial Ratio Analyser — Analyseur de ratios financiers
Target: Licence 3 / Master | Bilan + compte de résultat → liquidity, solvency, ROE,
rotation ratios with sector benchmarks and drag-to-restructure simulation.
3.5 Cash Flow Statement Builder — Constructeur de tableau de flux
Target: Master / professional | Indirect method; learner classifies events into
operating/investing/financing, validates against SYSCOHADA-Révisé format tableau.
Generated by automated daily review routine.
Generated by Claude Code