Daily review 2026-07-07

[NghaReformer]

Automated daily code and curriculum review for 2026-07-07.

Full report: reports/daily/2026-07-07.md

---

Summary

i18n parity: PASSED (1 331 keys, EN ↔ FR identical)
Svelte 5 runes: PASSED (zero banned Svelte 4 patterns)
Bugs found: 10 (2 high, 5 medium, 3 low)

---

Bugs & Issues

HIGH

1. src/lib/components/feedback/FeedbackForm.svelte:7 — Client Svelte component imports import type from $lib/server/db/types. SvelteKit boundary violation; any future value import would silently leak server code. Fix: move FeedbackType/FeedbackSeverity to a shared non-server types file.

2. src/routes/api/feedback/validation.ts:5 — File is not suffixed .server.ts but imports from $lib/server/db/types. SvelteKit cannot enforce the boundary. Fix: rename to validation.server.ts.

MEDIUM

3. CategoryBreakdownDonut.svelte:30-40 — CATEGORY_COLORS JS object with 9 hardcoded hex literals used as SVG strokes. Theme changes in tokens.ts won't affect these. Fix: read from getComputedStyle CSS custom properties at mount.

4. MatchingPairsOverlay.svelte:30-35 — COLOR JS object with 4 hardcoded hex literals for SVG connector lines. Same fix as above.

5. Six files — color: #fff / color: white — White text hardcoded on accent-colored backgrounds in learn/+page.svelte:202, chart-of-accounts/+page.svelte:423,458, EntryHistory.svelte:400, TransactionJournal.svelte:395, ScenarioWalkthrough.svelte:333,387. Fix: add --text-on-accent token.

6. ScheduleTable.svelte:215-267 (10 instances) — Direct rgba() values for flag/row tints without CSS variable wrappers. Fix: replace with color-mix(in srgb, var(--amber/--green/--error) N%, transparent).

7. CVP playground (12 instances) — background: rgba(255,255,255,0.02) used directly; --bg-subtle token already exists for this. Fix: replace with var(--bg-subtle).

8. ShareButton.svelte:22 — document.execCommand('copy') is deprecated and removed from the WHATWG spec. The app runs on HTTPS so the navigator.clipboard primary path always succeeds. Fix: remove the fallback branch.

LOW

9. CategoryBreakdownDonut.svelte:105 — Hardcoded English SVG text "items" bypasses i18n. Fix: accept an itemsLabel prop, add key to both locale files.

10. src/lib/data/playgrounds.ts:26-36 — Stale staticFile and lineCount for cvp and journal-entry (both now native modules; field is never read). Fix: remove staticFile, set lineCount: 0.

---

New Playground Ideas (5)

1. VAT / TVA Declaration Simulator — monthly input/output tax reconciliation → SYSCOHADA journal entries (accounts 4456/4457). Target: L2 / professional.
2. Fixed-Asset Register & Depreciation Tracker — multi-asset native module replacing the legacy iframe; year-by-year SYSCOHADA register with prorated acquisition support. Target: L3 / Master.
3. Payroll & Social Charges Calculator — gross→net salary slip with CNPS/IRPP by OHADA-zone country, maps to accounts 641/421/431. Target: L3 / professional.
4. Working Capital Analyser (BFR/FR/TN) — live derivation of BFR, FR, TN, and cash-conversion-cycle from balance-sheet inputs; sensitivity on DSO/DPO. Target: L3 / Master.
5. Financial Ratio Workbench — 12-ratio dashboard from a simplified SYSCOHADA balance sheet + P&L; sector benchmarks; what-if panel. Target: L3 / Master.

---

🤖 Generated with Claude Code

https://claude.ai/code/session_01KfSjvFSkKcF9VmSV9Fxhho

---

Generated by Claude Code

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
ohadalearn	Ready	Preview, Comment	Jul 7, 2026 11:19pm