Skip to content

Daily review 2026-07-12 - #76

Draft
NghaReformer wants to merge 1 commit into
mainfrom
daily-review/2026-07-12
Draft

Daily review 2026-07-12#76
NghaReformer wants to merge 1 commit into
mainfrom
daily-review/2026-07-12

Conversation

@NghaReformer

Copy link
Copy Markdown
Owner

Daily Review — 2026-07-12

Automated daily codebase review. Full report at reports/daily/2026-07-12.md.


Bugs & Issues (9 findings)

Severity File Summary
HIGH KpiStrip.svelte:76, LedgerPanel.svelte:175, VarianceScale.svelte:230 --orange CSS token doesn't exist; hardcoded #f59e0b fallback always fires instead of --amber
MEDIUM EntryHistory.svelte:400 Hardcoded color: #fff on .btn-confirm; should be var(--bg)
MEDIUM CategoryBreakdownDonut.svelte:30–40 9 hardcoded hex values in CATEGORY_COLORS used as SVG stroke + inline style
MEDIUM data/playgrounds.ts:26,35 staticFile field is dead code for cvp and journal-entry (native modules take precedence)
MEDIUM static/playgrounds/amortization-playground.html Orphaned legacy HTML — amortization is native-only; file is served but never linked
LOW WaitlistForm.svelte:55 Inline style= on honeypot div violates CLAUDE.md; FeedbackForm.svelte already shows the correct .hp class pattern
LOW playgrounds.en.ts:21–22 / playgrounds.fr.ts:21–22 pg.journal-entry.desc is placeholder copy; FR version has a grammar error (de écrituresd'écritures)
LOW Nav.svelte Mobile overlay: no click-outside-to-close handler; no focus trap (contrast: FeedbackDrawer has both)
LOW data/playgrounds.ts / journal-entry/manifest.ts pg.je.* (catalog) and pg.journal-entry.* (manifest) are parallel key sets for the same playground

New Playground Ideas (5)

  1. Inventory Valuation (FIFO · CUMP · LIFO) — Licence 2/3 — compare COGS and ending-inventory under PEPS/CUMP/DEPS with live stock-movement inputs
  2. Payroll & Social Charges Calculator — Licence 3 / Professional — jurisdiction-specific OHADA payroll slip + full journal entry (CNPS/IPRES/CSS splits)
  3. Financial Ratios Dashboard — Licence 3 / Master — live balance-sheet editor driving 15+ ratios with traffic-light thresholds and what-if toggles
  4. Deferred Tax Calculator (IAS 12 / SYSCOHADA) — Master / Professional — period-by-period deferred tax worksheet with journal entries and convergence chart
  5. Foreign Currency Transactions (IAS 21 / SYSCOHADA) — Licence 3 / Master — three-moment lifecycle (recognition → revaluation → settlement) with automatic forex gain/loss journal entries

See reports/daily/2026-07-12.md for full descriptions including pedagogical rationale, inputs/outputs, and architectural notes.


Generated by Claude Code

Co-Authored-By: Claude <noreply@anthropic.com>
@vercel

vercel Bot commented Jul 12, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
ohadalearn Ready Ready Preview, Comment Jul 12, 2026 11:18pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants