Conversation
Add comprehensive SECURITY.md and legal-notes.md documents to establish clear policies for vulnerability reporting, security scope, licensing boundaries, trademark usage, and contribution requirements. Update README.md to reference the new legal-notes.md document and mark the corresponding tasks as complete.
Add the initial ADB executable path resolution service. - add AdbPathResolver and AdbPathResult - check an optional custom ADB executable path - fall back to searching the current system PATH - support adb.exe and adb - return normalized absolute paths - report missing ADB through a structured failure result - keep the implementation independent from WinUI and process execution Closes #3.
Added a navigation section with links to website, organization, discussions, and issues near the top of the README. Also added information about the security policy and contact email for private security reports in the contributing section.
Add a reusable asynchronous process runner to WinDroid.Adb. - add ProcessRunner and CommandResult - launch executables directly without a shell - pass arguments safely through ProcessStartInfo.ArgumentList - capture stdout and stderr concurrently - return normal and non-zero exit codes - support timeout and caller cancellation - avoid launching when the caller token is already cancelled - terminate the process tree on timeout or cancellation - use bounded cleanup waits - return structured startup failures - keep the implementation separate from UI and ADB command parsing Closes #4.
Add a thin wrapper for running the adb devices command. - add AdbDeviceService and GetDevicesAsync - use the existing ProcessRunner - accept a caller-supplied resolved ADB path - pass exactly one argument: devices - forward timeout and cancellation unchanged - return the raw CommandResult unchanged - preserve stdout, stderr, exit code, timeout, cancellation, and startup failures - keep device parsing and UI integration out of scope Closes #5.
Prevent WinDroid Studio from crashing at startup when SENTRY_DSN is not configured. - initialize WinUI before optional Sentry setup - read SENTRY_DSN from the environment - only initialize Sentry when the DSN is non-empty - make the Sentry handle nullable - only flush and dispose Sentry when it was initialized - preserve normal window startup and shutdown behavior The app now launches successfully without Sentry configuration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request publishes the first stable WinDroid Runtime development foundation from
devtomain.It includes the initial ADB integration building blocks, a WinDroid Studio startup fix, manual verification of the current WinUI application, and a major README update defining the project’s developer-first direction and long-term shared-platform strategy.
Included work
ADB foundation
adb devicesWinDroid Studio
SENTRY_DSNis not configuredProject direction and documentation
Validation
git diff --checkis cleanadb devicesargument construction and raw result preservationScope
This PR does not add:
adb devicesoutputFollow-up
The next planned contributor task is Issue #6: parsing raw
adb devicesoutput into structured device models.Closes #3.
Closes #4.
Closes #5.