fix(recipes): let apk wait for the lock instead of failing - #33
Merged
Conversation
Another apk process holds the database lock briefly during boot provisioning. Without --wait, apk fails immediately with exit 99 and aborts the recipe.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
WalkthroughBundled Alpine installation scripts now wait up to 60 seconds for an existing APK package lock before failing. ChangesAPK package-lock handling
Estimated code review effort: 1 (Trivial) | ~5 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A provision run died with
ERROR: Unable to lock database: Resource temporarily unavailableand exit 99 when anotherapkheld the apk lock.Every
apk addin the bundled Alpine recipes (devtools, docker, tailscale, xfce) now passes--wait 60, so apk waits up to 60s for the lock instead of failing immediately.setup-apkreposandsetup-xorg-baseare alpine-conf helpers with no--waitflag, so they stay as they are; the per-VM provision lock (separate PR) removes the stoat-side source of contention.just checkandjust testpass.Summary by CodeRabbit