[18.0] [MIG] sale_commission_pricelist: Migration to 18.0 + rename sale_commission_pricelist_oca by Borruso · Pull Request #638 · OCA/commission

Borruso · 2025-08-29T15:30:06Z

No description provided.

pedrobaeza · 2025-09-01T17:28:26Z

/ocabot migration sale_commission_pricelist

github-actions · 2026-01-04T12:48:28Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

odooNextev · 2026-01-08T16:01:03Z

@Borruso can you relaunch tests?
Do you remember what was the problem?
I guess we're using this without problem, but it's been a while and we don't remember it's yours or the previous one.

Sign in to view

+    "license": "AGPL-3",
+    "depends": ["sale_commission_oca"],
+    "data": ["views/product_pricelist_view.xml"],
+    "pre_init_hook": "_sale_commission_pricelist_oca_pre_init_hook",


odooNextev

account_commission changed into account_commission_oca in the meantime

odooNextev · 2026-01-08T16:54:48Z

+
+from odoo.tests.common import Form
+
+from odoo.addons.account_commission.tests.test_account_commission import (


Suggested change

from odoo.addons.account_commission.tests.test_account_commission import (

from odoo.addons.account_commission_oca.tests.test_account_commission import (

odooNextev

LGTM

JordiMForgeFlow · 2026-03-23T11:15:08Z

@Borruso you should split one commit for the migration and one for the renaming. Also, the renaming should apply to all the history. You can see instructions here: #610 (comment)

And you can also see how it was done for other commission modules: https://github.com/OCA/commission/pull/610/commits

… pricelist item

Currently translated at 100.0% (3 of 3 strings) Translation: commission-12.0/commission-12.0-sale_commission_pricelist Translate-URL: https://translation.odoo-community.org/projects/commission-12-0/commission-12-0-sale_commission_pricelist/it/

Currently translated at 100.0% (3 of 3 strings) Translation: commission-12.0/commission-12.0-sale_commission_pricelist Translate-URL: https://translation.odoo-community.org/projects/commission-12-0/commission-12-0-sale_commission_pricelist/zh_CN/

Currently translated at 100.0% (3 of 3 strings) Translation: commission-12.0/commission-12.0-sale_commission_pricelist Translate-URL: https://translation.odoo-community.org/projects/commission-12-0/commission-12-0-sale_commission_pricelist/pt/

Currently translated at 100.0% (3 of 3 strings) Translation: commission-12.0/commission-12.0-sale_commission_pricelist Translate-URL: https://translation.odoo-community.org/projects/commission-12-0/commission-12-0-sale_commission_pricelist/pt_BR/

Currently translated at 100.0% (3 of 3 strings) Translation: commission-13.0/commission-13.0-sale_commission_pricelist Translate-URL: https://translation.odoo-community.org/projects/commission-13-0/commission-13-0-sale_commission_pricelist/es_AR/

Currently translated at 100.0% (3 of 3 strings) Translation: commission-14.0/commission-14.0-sale_commission_pricelist Translate-URL: https://translation.odoo-community.org/projects/commission-14-0/commission-14-0-sale_commission_pricelist/it/

Currently translated at 100.0% (3 of 3 strings) Translation: commission-14.0/commission-14.0-sale_commission_pricelist Translate-URL: https://translation.odoo-community.org/projects/commission-14-0/commission-14-0-sale_commission_pricelist/pt_BR/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: commission-14.0/commission-14.0-sale_commission_pricelist Translate-URL: https://translation.odoo-community.org/projects/commission-14-0/commission-14-0-sale_commission_pricelist/

Currently translated at 100.0% (6 of 6 strings) Translation: commission-14.0/commission-14.0-sale_commission_pricelist Translate-URL: https://translation.odoo-community.org/projects/commission-14-0/commission-14-0-sale_commission_pricelist/it/

Currently translated at 100.0% (6 of 6 strings) Translation: commission-14.0/commission-14.0-sale_commission_pricelist Translate-URL: https://translation.odoo-community.org/projects/commission-14-0/commission-14-0-sale_commission_pricelist/es/

Borruso · 2026-03-24T12:14:44Z

@Borruso you should split one commit for the migration and one for the renaming. Also, the renaming should apply to all the history. You can see instructions here: #610 (comment)

And you can also see how it was done for other commission modules: https://github.com/OCA/commission/pull/610/commits

can you check?

JordiMForgeFlow · 2026-03-24T12:27:14Z

@Borruso looks good! one question, why the init hook?

OCA-git-bot · 2026-03-31T20:49:13Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot added this to the 18.0 milestone Sep 1, 2025

OCA-git-bot mentioned this pull request Sep 1, 2025

Migration to version 18.0 #564

Open

7 tasks

IsabelAForgeFlow mentioned this pull request Sep 4, 2025

[18.0][MIG] Migration of module sale_commission_pricelist to 18.0 #604

Closed

github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 4, 2026

Borruso force-pushed the 18.0-mig-sale_commission_pricelist_oca branch from 1790e6a to 612c332 Compare January 8, 2026 16:23

odooNextev reviewed Jan 8, 2026

View reviewed changes

Comment thread sale_commission_pricelist_oca/__manifest__.py

"license": "AGPL-3",

"depends": ["sale_commission_oca"],

"data": ["views/product_pricelist_view.xml"],

"pre_init_hook": "_sale_commission_pricelist_oca_pre_init_hook",

This comment was marked as resolved.

Sign in to view

Borruso force-pushed the 18.0-mig-sale_commission_pricelist_oca branch from 612c332 to a2d5779 Compare January 8, 2026 16:47

odooNextev suggested changes Jan 8, 2026

View reviewed changes

github-actions Bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 11, 2026

Borruso force-pushed the 18.0-mig-sale_commission_pricelist_oca branch from a2d5779 to 78f62a3 Compare January 12, 2026 08:11

odooNextev approved these changes Jan 12, 2026

View reviewed changes

carlosdauden and others added 15 commits March 24, 2026 13:13

[ADD] sale_commission_pricelist: New module that assign commission to…

0f6c52c

… pricelist item

[FIX] sale_commission_pricelist: Make this to work on button recompute

5f70e1e

porting sale_commission_pricelist to 11.0

177f8af

Added translation using Weblate (German)

14e5eb3

[MIG] sale_commission_pricelist: Migration to 12.0

09a7a41

Translated using Weblate (Italian)

2673897

Currently translated at 100.0% (3 of 3 strings) Translation: commission-12.0/commission-12.0-sale_commission_pricelist Translate-URL: https://translation.odoo-community.org/projects/commission-12-0/commission-12-0-sale_commission_pricelist/it/

Added translation using Weblate (Chinese (Simplified))

024b035

Added translation using Weblate (Portuguese)

6247db6

Translated using Weblate (Portuguese)

ee84a93

Currently translated at 100.0% (3 of 3 strings) Translation: commission-12.0/commission-12.0-sale_commission_pricelist Translate-URL: https://translation.odoo-community.org/projects/commission-12-0/commission-12-0-sale_commission_pricelist/pt/

Added translation using Weblate (Portuguese (Brazil))

00a05b3

[IMP] sale_commission_pricelist: black, isort, prettier

fec0a09

[MIG] sale_commission_pricelist: Migration to 13.0

fe1a9a5

ibuioli and others added 15 commits March 24, 2026 13:13

Added translation using Weblate (Spanish (Argentina))

9158780

Update inherited view with new field.

d4e0f2f

[IMP] sale_commission_pricelist: black, isort, prettier

08a0ff8

[MIG] sale_commission_pricelist: Migration to 14.0

215984e

Translated using Weblate (Italian)

3de6255

Currently translated at 100.0% (3 of 3 strings) Translation: commission-14.0/commission-14.0-sale_commission_pricelist Translate-URL: https://translation.odoo-community.org/projects/commission-14-0/commission-14-0-sale_commission_pricelist/it/

Translated using Weblate (Italian)

c01fde0

Currently translated at 100.0% (6 of 6 strings) Translation: commission-14.0/commission-14.0-sale_commission_pricelist Translate-URL: https://translation.odoo-community.org/projects/commission-14-0/commission-14-0-sale_commission_pricelist/it/

Translated using Weblate (Spanish)

c74aa28

Currently translated at 100.0% (6 of 6 strings) Translation: commission-14.0/commission-14.0-sale_commission_pricelist Translate-URL: https://translation.odoo-community.org/projects/commission-14-0/commission-14-0-sale_commission_pricelist/es/

[IMP] sale_commission_pricelist: pre-commit auto fixes

d355310

[MIG] sale_commission_pricelist: Migration to 17.0

6ea9334

[MIG] sale_commission_pricelist: Migration to 18.0

8bffc96

[MOV] sale_commission_pricelist: rename to sale_commission_pricelist_oca

e539c0a

[FIX] sale_commission_pricelist_oca: fix tests after renaming

e456129

Borruso force-pushed the 18.0-mig-sale_commission_pricelist_oca branch from 1e80a30 to e456129 Compare March 24, 2026 12:13

sergiocorato approved these changes Mar 31, 2026

View reviewed changes

OCA-git-bot added approved ready to merge labels Mar 31, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[18.0] [MIG] sale_commission_pricelist: Migration to 18.0 + rename sale_commission_pricelist_oca#638

[18.0] [MIG] sale_commission_pricelist: Migration to 18.0 + rename sale_commission_pricelist_oca#638
Borruso wants to merge 30 commits intoOCA:18.0from
Borruso:18.0-mig-sale_commission_pricelist_oca

Borruso commented Aug 29, 2025

Uh oh!

pedrobaeza commented Sep 1, 2025

Uh oh!

github-actions Bot commented Jan 4, 2026

Uh oh!

odooNextev commented Jan 8, 2026

Uh oh!

This comment was marked as resolved.

Uh oh!

odooNextev left a comment

Uh oh!

odooNextev Jan 8, 2026

Uh oh!

odooNextev Jan 12, 2026

Uh oh!

odooNextev left a comment

Uh oh!

JordiMForgeFlow commented Mar 23, 2026

Uh oh!

Borruso commented Mar 24, 2026

Uh oh!

JordiMForgeFlow commented Mar 24, 2026

Uh oh!

OCA-git-bot commented Mar 31, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants


		from odoo.tests.common import Form

		from odoo.addons.account_commission.tests.test_account_commission import (

	from odoo.addons.account_commission.tests.test_account_commission import (
	from odoo.addons.account_commission_oca.tests.test_account_commission import (

Uh oh!

Conversation

Borruso commented Aug 29, 2025

Uh oh!

pedrobaeza commented Sep 1, 2025

Uh oh!

github-actions Bot commented Jan 4, 2026

Uh oh!

odooNextev commented Jan 8, 2026

Uh oh!

This comment was marked as resolved.

Uh oh!

odooNextev left a comment

Choose a reason for hiding this comment

Uh oh!

odooNextev Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

odooNextev Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

odooNextev left a comment

Choose a reason for hiding this comment

Uh oh!

JordiMForgeFlow commented Mar 23, 2026

Uh oh!

Borruso commented Mar 24, 2026

Uh oh!

JordiMForgeFlow commented Mar 24, 2026

Uh oh!

OCA-git-bot commented Mar 31, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants