[17.0][FIX] base_geoengine: filtered domain geo operators#458
Open
zamberjo wants to merge 2 commits into
Open
Conversation
96f5565 to
ecb4fc6
Compare
maurochip
approved these changes
May 20, 2026
sersanchus
approved these changes
May 20, 2026
Contributor
|
This PR has the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Odoo evaluates
ir.ruledomains in-memory viaBaseModel._filter_access_rules_python()→filtered_domain(), which has a hardcoded operator dispatch (if/elifchain) that raisesValueErrorfor any operator it doesn't recognize.While base_geoengine already patches
expression.TERM_OPERATORSand__leaf_to_sqlto support geo operators (geo_within,geo_intersect, etc.) during SQL query compilation, the Python-sidefiltered_domain()is a completely separate code path that was never extended.This fix patches
filtered_domainto detect geo operator leaves and fall back to a SQLsearch()call (where PostGIS can resolve them), following the same delegation pattern Odoo already uses forchild_ofandparent_ofoperators.