[18.0][MIG] hr_payroll_document: Migration to 18.0#268
Conversation
OCA-git-bot
added
series:18.0
mod:hr_payroll_document
anusriNPS
force-pushed
the
18.0-mig-hr_payroll_document
branch
from
d051eea to
24de647
Compare
|
@peluko00 as the module's maintainer, please have a look. |
SirPyTech
left a comment
SirPyTech
left a comment
There was a problem hiding this comment.
Thanks for the PR!
I reviewed the code and it is fine, please double check the commit history.
I also tried the module locally and seems to be working great!
praise: Thanks for trying to keep the history from #239!
I think it's ok to create new migration commits if cherry picking those ones was too hard.
There was a problem hiding this comment.
chore: This commit 41563b7 has disappeared, please check
There was a problem hiding this comment.
Thank you for catching it. Missed it thinking it's a bot commit. Included in the latest patchset
There was a problem hiding this comment.
chore: I see you have squashed many commits, but there are still a few bot commits: 
Please squash them according to https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate.
There was a problem hiding this comment.
Squashed all bot commits as described on the above link
Currently translated at 100.0% (39 of 39 strings) Translation: payroll-17.0/payroll-17.0-hr_payroll_document Translate-URL: https://translation.odoo-community.org/projects/payroll-17-0/payroll-17-0-hr_payroll_document/it/
anusriNPS
force-pushed
the
18.0-mig-hr_payroll_document
branch
from
24de647 to
884075f
Compare
Seems good, only squash commits please @anusriNPS and LGTM! |
5 participants
Supersedes #239. This PR includes latest commits from 17.0 for hr_payroll_document and also addresses comments from #239
Note:
Could not restore original author commits from #239 while using
odoo-module-migratoror handling migration using manual steps mentioned in https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-18.0#technical-method-to-migrate-a-module-from-170-to-180-branch.So, introduced as fresh migration of hr_payroll_document in 18.0