Skip to content

feat: added conventional commits shared workflow#24

Merged
rpignolet merged 2 commits into
OKDP:mainfrom
jpmewenemesse:feat/conventional-commits-workflow
Jun 12, 2026
Merged

feat: added conventional commits shared workflow#24
rpignolet merged 2 commits into
OKDP:mainfrom
jpmewenemesse:feat/conventional-commits-workflow

Conversation

@jpmewenemesse

@jpmewenemesse jpmewenemesse commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Description

Add a reusable Github Actions workflow to enforce conventional commits accross all OKDP repos.

Related Issue

Fixes #23

Type of Change

  • Bug fix
  • New feature
  • Documentation update
  • Refactor / chore
  • Breaking change

How to Test

Once merged, and once usage is added to org repos, test that conventional commits is enforced in commits messages

Checklist

  • I have tested my changes
  • Documentation updated if needed
  • If breaking change: migration path described above
  • I hereby declare this contribution to be licensed under the Apache License Version 2.0.
  • I hereby agree to grant TOSIT a copyright license to use my contributions.

@jpmewenemesse jpmewenemesse force-pushed the feat/conventional-commits-workflow branch from 82a3610 to 6b0b0a4 Compare June 9, 2026 08:13
@jpmewenemesse jpmewenemesse self-assigned this Jun 9, 2026
@jpmewenemesse jpmewenemesse added the enhancement New feature or request label Jun 9, 2026
@jpmewenemesse jpmewenemesse requested review from a team June 9, 2026 11:59
@PaulFarault

Copy link
Copy Markdown

Is there any alternatives that could be both used as an action AND ran locally? Or are we ok with only checking conventions through GitHub?

@jpmewenemesse

Copy link
Copy Markdown
Contributor Author

Is there any alternatives that could be both used as an action AND ran locally? Or are we ok with only checking conventions through GitHub?

It is possible via pre-commit hooks locally

@PaulFarault

Copy link
Copy Markdown

Is there any alternatives that could be both used as an action AND ran locally? Or are we ok with only checking conventions through GitHub?

It is possible via pre-commit hooks locally

As I understand it, the webiny/action-conventional-commits GitHub Action and the conventional-pre-commit pre-commit hook are unrelated, aside from both being based on the Conventional Commits specification.

I was suggesting that we use the same tool across all environments for consistency, if that makes sense.

@jpmewenemesse

Copy link
Copy Markdown
Contributor Author

Is there any alternatives that could be both used as an action AND ran locally? Or are we ok with only checking conventions through GitHub?

It is possible via pre-commit hooks locally

As I understand it, the webiny/action-conventional-commits GitHub Action and the conventional-pre-commit pre-commit hook are unrelated, aside from both being based on the Conventional Commits specification.

I was suggesting that we use the same tool across all environments for consistency, if that makes sense.

Not sure if this is possible

@rpignolet rpignolet merged commit d1c9758 into OKDP:main Jun 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: Add shared conventional commits workflow

3 participants