make: set plugin SONAME to the installed filename - #137
Open
BKPepe wants to merge 1 commit into
Open
Conversation
The plugins are linked with SONAME lib$(PLUGIN_NAME).so, but they are
installed as $(PLUGIN_NAME).so.$(PLUGIN_VER) and loaded via dlopen()
using that filename. A library whose SONAME does not match any
installed filename confuses tooling which verifies that a symlink
named after the SONAME exists, for example the OpenWrt CI runtime
tests:
Library /usr/lib/olsrd_arprefresh.so.0.1 has SONAME
'libolsrd_arprefresh.so' but no corresponding symlink was found
Use the full installed filename as SONAME instead. This has no
functional effect on olsrd itself, since the plugins are dlopen()ed
by path and never linked against.
Signed-off-by: Josef Schlehofer <pepe.schlehofer@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The plugins are linked with SONAME
lib$(PLUGIN_NAME).so, but they are installed as$(PLUGIN_NAME).so.$(PLUGIN_VER)and loaded via dlopen() using that filename. A library whose SONAME does not match any installed filename confuses tooling which verifies that a symlink named after the SONAME exists, for example the OpenWrt CI runtime tests:Use the full installed filename as SONAME instead. This has no functional effect on olsrd itself, since the plugins are dlopen()ed by path and never linked against.
This is currently carried as a downstream patch in the OpenWrt routing feed (openwrt/routing#1191) and it would be nice to drop it with the next update.