HotFix 2#1931
Merged
JoshuaSBrown merged 34 commits intostagingfrom Apr 1, 2026
Merged
Conversation
…tractions from core server.
#1861) * fix: prevent defaults being set to undefined, and interpret numbers and enums as strings. * chore: Auto-format JavaScript files with Prettier
…nance, metricThread and task_worker (#1885) Co-authored-by: Joshua S Brown <joshbro42867@yahoo.com> Co-authored-by: Joshua S Brown <brownjs@ornl.gov>
…, to hit feature parity with web ser… (#1859)
…mat, and metadata format (#1894)
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
…ce with API spec file. (#1903)
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
…e and default to different database for tests (#1917)
… cmake (#1918) Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates release metadata and schema version handling to append an explicit ':' suffix on schema IDs, aligning the web service and Foxx API behavior with the Python client for schema create and search operations, and bumps related patch versions. Sequence diagram for schema create with implicit version suffix handlingsequenceDiagram
actor Client
participant WebServer as WebServer_datafed_ws
participant CoreAPI as Foxx_schema_router
Client->>WebServer: POST /api/sch/create { id: schema_id, body: ... }
alt id has no version suffix
WebServer->>WebServer: Append ":0" to a_req.body.id
else id already includes version suffix
WebServer->>WebServer: Keep a_req.body.id unchanged
end
WebServer->>CoreAPI: sendMessage SchemaCreateRequest(id, body, ...)
CoreAPI-->>WebServer: SchemaCreateReply
WebServer-->>Client: JSON response
Sequence diagram for schema search returning version-qualified IDssequenceDiagram
actor Client
participant WebServer as WebServer_datafed_ws
participant CoreAPI as Foxx_schema_router
Client->>WebServer: POST /api/sch/search { query, offset, count }
WebServer->>CoreAPI: sendMessage SchemaSearchRequest(query, offset, count, ...)
CoreAPI->>CoreAPI: AQL RETURN {_id, id: CONCAT(i.id,':',TO_STRING(i.ver)), ver, ...}
CoreAPI-->>WebServer: Search results with id including :ver suffix
WebServer-->>Client: JSON results with version-qualified ids
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The
idnormalization to append:0is currently applied only inweb/datafed-ws.js; consider centralizing this logic on the backend (or in a shared helper) so all clients and code paths enforce the same schema ID format consistently. - In
schema_router.js,CONCAT(i.id,':',TO_STRING(i.ver))assumesi.idnever already includes a version suffix; if that assumption might not always hold, add a guard or a short comment documenting the invariant to avoid accidentally double-appending versions in the future.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The `id` normalization to append `:0` is currently applied only in `web/datafed-ws.js`; consider centralizing this logic on the backend (or in a shared helper) so all clients and code paths enforce the same schema ID format consistently.
- In `schema_router.js`, `CONCAT(i.id,':',TO_STRING(i.ver))` assumes `i.id` never already includes a version suffix; if that assumption might not always hold, add a guard or a short comment documenting the invariant to avoid accidentally double-appending versions in the future.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Update version metadata and fix schema ID version handling across web API and Foxx schema router.
Bug Fixes:
Enhancements:
Build: