Fix running a Model with footprint file via AwsS3Storage#49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix running a Model with footprint file via AwsS3Storage
FileNotFoundErrorto detectBefore this fix that would cause
TypeError, fixed soFileNotFoundErroris raised when not found in bucketpublic_bucket(bool) option that setsanon = Truein the S3 client settings, (anonymous user) this need an explicit setting because it prevents boto3 'walking the chain' of credentials. (for example EC2 instance with an S3 access role attached)