[25] Add holiday adjustment#78
Open
ncouvert wants to merge 1 commit into
Open
Conversation
ncouvert
force-pushed
the
nco/enh/working-days
branch
from
d03f864 to
f815a2f
Compare
ncouvert
force-pushed
the
nco/enh/working-days
branch
from
f815a2f to
6234af8
Compare
ncouvert
force-pushed
the
nco/enh/working-days
branch
from
6234af8 to
499ce91
Compare
Collaborator
Author
|
This PR introduces changes to It is still possible to create a task that starts or ends on a weekend from the Explorer view. I'm currently working on this issue, but reusing the business logic implemented in This will require some refactoring to resolve. |
ncouvert
force-pushed
the
nco/enh/working-days
branch
from
499ce91 to
8c0493c
Compare
Issue: #25 Bug: Tasks with dependencies may incorrectly extend indefinitely. If a task is repeatedly moved backward by less than two days and this causes the end date of one of its dependencies to fall on a weekend, the dependent task may keep growing on each recalculation.
ncouvert
force-pushed
the
nco/enh/working-days
branch
from
8c0493c to
10526f0
Compare
Collaborator
|
Proposal:
As an enhancement, we could imagine having visual information to know if a task is constraint by its duration or not |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #25
Bug: Tasks with dependencies may incorrectly extend indefinitely. If a task is repeatedly moved backward by less than two days and this causes the end date of one of its dependencies to fall on a weekend, the dependent task may keep growing on each recalculation.