fix: cherry-pick Miga Labs #271 nil committee panic fix#6
Open
anadi2311 wants to merge 1 commit into
Open
Conversation
A transient beacon-node/proxy failure (e.g. 'unexpected EOF') while fetching committees made NewEpochData swallow the error and build a state with empty committees. ElectraMetrics.GetAttestingIndices then dereferenced a nil committee, crashing the whole indexer with a SIGSEGV; the legacy Altair/Deneb path had the same latent hazard via an out-of-range slice access. Root cause fix: NewEpochData now retries the committees/proposer-duties fetch up to --max-request-retries and returns an error on failure, so the state download is retried instead of caching a state with empty committees. Defense in depth: GetAttestingIndices (Electra) and GetValidatorFromCommitteeIndex (Altair/Deneb) now return a clear error on a missing committee instead of panicking, and the Electra attestation path propagates it for a graceful shutdown rather than log.Fatalf. Adds unit tests covering the missing-committee guards.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-picks migalabs/goteth@4bc5c76 from
fix/issue-271-nil-committee-paniconto Obolmaster.NewEpochDataretries committee/proposer-duties fetch (up to--max-request-retries) and fails the state download instead of caching empty committees after transient Beacon errors (e.g.unexpected EOF).GetAttestingIndices/GetValidatorFromCommitteeIndexreturn errors on missing committees instead of nil-panicking.Fixes the Electra indexer crash reported in production/Hoodi canary (internal notes /
GOTETH_MIGALABS_ISSUE_ELECTRA_PANIC.md).Test plan
hoodi_canary) with historical range2872756–2887128beacon committeeserrors retry and pod does not panic