fix(audit): handle Redis read timeouts - #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Redis read timeout crash loop
Problem
The security-audit worker could terminate when the blocking Redis
XREADGROUP operation reached the redis-py socket read timeout while the
stream was idle.
Docker would restart the worker, causing a recurring crash loop approximately
every five seconds.
Fix
Handle the expected Redis read timeout at the worker's outer blocking-read
boundary so an idle stream does not terminate the worker process.
Unexpected exceptions remain distinguishable and are not silently swallowed.
Regression coverage
Tests verify:
Validation
Scope
This PR only fixes the worker's Redis read-timeout handling.
No Interaction implementation is included.
No API Gateway changes are included.
No Control Center changes are included.
No authentication/session changes are included.