config: wire bio_agent TES service-account credentials into workbench (#195) - #34
Merged
Merged
Conversation
… (#195) Companion to OmniBioAI/omnibioai-workbench#201 -- that PR alone has no effect until this also lands. Same repo-split pattern as #29 (ORCHESTRATOR_MAX_RETRIES). Adds BIO_AGENT_AUTH_URL/BIO_AGENT_SVC_EMAIL/BIO_AGENT_SVC_PASSWORD to the workbench service's environment block, next to the existing LIMS_* vars (same scope -- workbench only, not celery-worker, matching precedent). Real credential values already live in the (gitignored) .env for this deployment; this PR only adds the compose wiring + ${VAR:-} defaults. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Config-only companion to
OmniBioAI/omnibioai-workbench#201(bio_agent TESworkflow.executefix, #195). That PR alone has no effect in this deployment until this one also lands -- same repo-split pattern as #29 (ORCHESTRATOR_MAX_RETRIES).Adds to the
workbenchservice'senvironment:block, next to the existingLIMS_*vars (same scope -- workbench only, not celery-worker, matching that precedent):What this does NOT touch
docker-compose.ymlonly..env, written when the dedicatedsvc-bio-agent@omnibioai.internalscientist-role service account was created (#195's 1b). This PR only adds the compose plumbing +${VAR:-}defaults so a deployment without that.enventry degrades to an empty credential (same fail-open behavior as before, see the companion PR's description).Testing
Verified together with the companion PR: rebuilt + recreated
workbenchwith both changes applied, real credentials supplied from.env, and confirmed an actual TES submission succeeds end-to-end (run_id=run_1m3A8NcvLHnGfw,state=SUBMITTED) -- not just that the env vars are present.Closes #195
🤖 Generated with Claude Code