fix(#196): add GATEWAY_URL to celery-worker - #42
Merged
Conversation
workbench already had this; celery-worker didn't. The 4 TES call sites fixed in omnibioai-workbench#196 (bio_agent's two factories, step_executor.py, workflow_runner/views.py, catalog/services.py) now read GATEWAY_URL exclusively to route through api-gateway instead of straight to TES. Deliberately NOT repointing TES_BASE_URL/OMNIBIOAI_TES_URL to the gateway on either service: traced every remaining reader of those two vars first, and found two more (bioquery_tasks.py's Celery flow, filed as omnibioai-workbench#209; and a separate OMNIBIOAI_TES_PROFILES routing subsystem in core/config.py, filed as #210) that carry no bearer token at all. Repointing the shared env vars would have silently 401'd those instead of leaving them at their pre-existing (bypassing, but working) behavior. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
workbenchalready hadGATEWAY_URL: http://api-gateway:8080;celery-workerdidn't. The 4 TES call sites fixed in omnibioai-workbench#196 (bio_agent's two_tes()factories,step_executor.py,workflow_runner/views.py,catalog/services.py) now readGATEWAY_URLexclusively to route through api-gateway instead of straight to TES.Deliberately NOT repointing TES_BASE_URL/OMNIBIOAI_TES_URL
Traced every remaining reader of those two vars before touching them, and found two more that carry no bearer token at all:
bioquery_tasks.py's Celery flow -- filed as omnibioai-workbench#209OMNIBIOAI_TES_PROFILESrouting subsystem (core/config.py) -- filed as omnibioai-workbench#210Repointing the shared env vars would have silently 401'd those instead of leaving them at their pre-existing (bypassing, but working) behavior.
TES_BASE_URL/OMNIBIOAI_TES_URLstay pointed athttp://tes:8081on both services.Verification
Full end-to-end pass against the live stack, all 4 sites, real data (not just "no error thrown"):
_tes()run_c5Wuj60HD8C1Zg), polled tostate: COMPLETED,organization_idcorrectly stamped (357)step_executor._run_tes()run_OxYN5BkoilJShw), confirmedstate: COMPLETEDworkflow_runner._fetch_tes_logs()catalog.CatalogService._load_tes_servers()Authorizationheader confirmed presentAlso found and fixed (separate PR, not bundled here) a pre-existing, unrelated TES run-store MySQL credentials gap that was blocking every real submission regardless of gateway routing -- see omnibioai-studio#41.
Not merging -- flagging for review.
🤖 Generated with Claude Code