Enable Sign out during initial FullPage capture#667
Merged
Conversation
Sign out was disabled on dialog open and only re-enabled when the full-page capture finished, so switching to another mode mid-capture left it stuck disabled. Lock Sign out only during the save round-trip (via lock/unlockSidebar) instead, and abort any in-flight capture when the user signs out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On opening the clipper, Sign out was disabled while the initial full-page capture ran, and only re-enabled once that capture completed. Since mode buttons stay interactive during capture (added in "Allow mode switching during initial FullPage capture"), a user could switch to Article/Selection/Bookmark/Region before the capture finished — and in those modes Sign out was never re-enabled, leaving it stuck disabled.
Root cause
disableSignout()fired on dialog open and inswitchToFullPage(). Sign out was only re-enabled by capture completion (finalize), PDF mode, or the no-capture invoke path — none of which run when the user pivots to another mode mid-capture.Fix
disableSignout()calls. Sign out now locks only during the save round-trip, vialockSidebar()/unlockSidebar().enableSignout()calls (PDF mode, no-capture ready state, finalize, sign-out reset), so Sign out state is driven entirely by lock/unlock.Net invariant: Sign out state == save-lock state, always.
Testing
npm run buildclean (compile + lint)