Skip to content

A11y Bug 10987406: Announce actual font size value on increase/decrease in Article mode. #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aanchalbhansali merged 3 commits into from
Jul 7, 2026
Merged

A11y Bug 10987406: Announce actual font size value on increase/decrease in Article mode. #669

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
13c2413
Initial plan
Copilot Jul 6, 2026
fb28f76
fix: announce updated font size value to screen reader on increase/de…
Copilot Jul 6, 2026
114131a
Merge remote-tracking branch 'origin/master' into copilot/fix-screen-…
Copilot Jul 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/scripts/renderer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,6 +257,8 @@ let strings = {
changeFontSerif: loc("WebClipper.Accessibility.ScreenReader.ChangeFontToSerif", "Change font to Serif"),
decreaseFontSize: loc("WebClipper.Accessibility.ScreenReader.DecreaseFontSize", "Decrease font size"),
increaseFontSize: loc("WebClipper.Accessibility.ScreenReader.IncreaseFontSize", "Increase font size"),
fontSizeDecreasedTo: loc("WebClipper.Accessibility.ScreenReader.FontSizeDecreasedTo", "Font size decreased to {0}"),
fontSizeIncreasedTo: loc("WebClipper.Accessibility.ScreenReader.FontSizeIncreasedTo", "Font size increased to {0}"),
sansSerifLabel: loc("WebClipper.Preview.Header.SansSerifButtonLabel", "Sans-serif"),
serifLabel: loc("WebClipper.Preview.Header.SerifButtonLabel", "Serif"),
fontFamilySerif: loc("WebClipper.FontFamily.Preview.SerifDefault", "Georgia"),
Expand Down Expand Up @@ -1532,14 +1534,14 @@ fontDecreaseBtn.addEventListener("click", () => {
articleFontSize -= 2;
applyArticleFontSize();
updateFontSizeButtonStates();
announceToScreenReader(strings.decreaseFontSize);
announceToScreenReader(strings.fontSizeDecreasedTo.replace("{0}", "" + articleFontSize));
});
fontIncreaseBtn.addEventListener("click", () => {
if (articleFontSize >= 72) { return; }
articleFontSize += 2;
applyArticleFontSize();
updateFontSizeButtonStates();
announceToScreenReader(strings.increaseFontSize);
announceToScreenReader(strings.fontSizeIncreasedTo.replace("{0}", "" + articleFontSize));
});

// Highlighter toggle
Expand Down
Loading