Allow install_deps.sh to be run standalone as an upgrader (without setup.cmd)#673
Open
mcarans wants to merge 4 commits into
Open
Allow install_deps.sh to be run standalone as an upgrader (without setup.cmd)#673mcarans wants to merge 4 commits into
mcarans wants to merge 4 commits into
Conversation
allow install_deps.sh to be run standalone as an upgrader (without setup.cmd)
mcarans
requested review from
AnotherCommander,
Kaks,
KonstantinosSykas,
dsalt,
ericwalch,
jobi-wan,
kanthoney,
mwerle,
oocube and
phkb
as code owners
Contributor
Author
|
@kanthoney @phkb This PR should fix the issue you both raised with upgrading an existing MSYS2 as well as fixing the gcc build on that platform. I usually set up gcc on MINGW64 and clang on UCRT64. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove sourcing of GNUstep.sh
Also fix gcc build on msys2
Reformat install_deps.sh to be 4 spaced
Fixes #668
Fixes #670
Fixes #675