Skip to content

feat(ai-provider): default MiniMax to the current MiniMax-M3 model - #87

Open
octo-patch wants to merge 1 commit into
Open-Dev-Society:mainfrom
octo-patch:octo/20260729-model-add-recvq9hH1JfM5I
Open

feat(ai-provider): default MiniMax to the current MiniMax-M3 model#87
octo-patch wants to merge 1 commit into
Open-Dev-Society:mainfrom
octo-patch:octo/20260729-model-add-recvq9hH1JfM5I

Conversation

@octo-patch

@octo-patch octo-patch commented Jul 29, 2026

Copy link
Copy Markdown

Reason: The MiniMax provider still defaulted to a superseded model and did not expose the current MiniMax-M3 model.

What changed

  • lib/ai-provider.ts: the MiniMax provider now defaults to the current MiniMax-M3 model instead of the previous one. The MINIMAX_MODEL environment variable still overrides the default, so the earlier MiniMax-M2.7 model remains selectable.
  • __tests__/ai-provider.test.ts: updated the two assertions that pinned the default MiniMax model so they expect MiniMax-M3.
  • __tests__/ai-provider.integration.test.ts: updated the integration test title to reference MiniMax-M3.

The change follows the existing provider pattern: a single string default that can be overridden via MINIMAX_MODEL. No endpoint, base URL, or request-shape changes were made.

Checks

  • npm test — 79 passed, 4 skipped (live-key integration tests).
  • npx eslint lib/ai-provider.ts __tests__/ai-provider.test.ts __tests__/ai-provider.integration.test.ts — 0 errors.

Summary by CodeRabbit

  • New Features

    • Updated the default MiniMax model to MiniMax-M3.
    • Existing configuration options can still override the default model.
  • Tests

    • Updated provider and integration coverage to validate MiniMax-M3 requests and responses.

The MiniMax provider defaulted to a superseded model and did not expose
the current MiniMax-M3 model. Default to MiniMax-M3 while keeping the
MINIMAX_MODEL override, and update the tests that pinned the old default.
@vercel

vercel Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

@octo-patch is attempting to deploy a commit to the ravixalgorithm's projects Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The MiniMax provider default model changed from MiniMax-M2.7 to MiniMax-M3. Unit and integration tests were updated to reflect the new default and request model.

Changes

MiniMax model update

Layer / File(s) Summary
MiniMax default and validation
lib/ai-provider.ts, __tests__/ai-provider.test.ts, __tests__/ai-provider.integration.test.ts
The default MiniMax model, API request expectation, configuration expectation, and integration test label now use MiniMax-M3.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely summarizes the main change: MiniMax now defaults to the M3 model.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Fix failing CI checks
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@__tests__/ai-provider.integration.test.ts`:
- Line 13: Update the test named “generates a response from MiniMax M3” so its
behavior matches the title: pin MINIMAX_MODEL to MiniMax-M3 for the test and
restore the prior environment value during cleanup, or rename the test to be
model-neutral if it intentionally supports configurable models.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 396d54e0-8c17-408c-9575-31a3f39df857

📥 Commits

Reviewing files that changed from the base of the PR and between 4597c9a and 99bab91.

📒 Files selected for processing (3)
  • __tests__/ai-provider.integration.test.ts
  • __tests__/ai-provider.test.ts
  • lib/ai-provider.ts

"MiniMax integration",
() => {
it("generates a response from MiniMax M2.7", async () => {
it("generates a response from MiniMax M3", async () => {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Do not claim this test always exercises MiniMax M3.

Because MINIMAX_MODEL remains configurable and this test neither sets nor asserts it, an environment override can make the test run against another model. Either pin MINIMAX_MODEL to MiniMax-M3 for this test with proper cleanup, or use a model-neutral title.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@__tests__/ai-provider.integration.test.ts` at line 13, Update the test named
“generates a response from MiniMax M3” so its behavior matches the title: pin
MINIMAX_MODEL to MiniMax-M3 for the test and restore the prior environment value
during cleanup, or rename the test to be model-neutral if it intentionally
supports configurable models.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant