feat(ai-provider): default MiniMax to the current MiniMax-M3 model - #87
feat(ai-provider): default MiniMax to the current MiniMax-M3 model#87octo-patch wants to merge 1 commit into
Conversation
The MiniMax provider defaulted to a superseded model and did not expose the current MiniMax-M3 model. Default to MiniMax-M3 while keeping the MINIMAX_MODEL override, and update the tests that pinned the old default.
|
@octo-patch is attempting to deploy a commit to the ravixalgorithm's projects Team on Vercel. A member of the Team first needs to authorize it. |
📝 WalkthroughWalkthroughThe MiniMax provider default model changed from ChangesMiniMax model update
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@__tests__/ai-provider.integration.test.ts`:
- Line 13: Update the test named “generates a response from MiniMax M3” so its
behavior matches the title: pin MINIMAX_MODEL to MiniMax-M3 for the test and
restore the prior environment value during cleanup, or rename the test to be
model-neutral if it intentionally supports configurable models.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 396d54e0-8c17-408c-9575-31a3f39df857
📒 Files selected for processing (3)
__tests__/ai-provider.integration.test.ts__tests__/ai-provider.test.tslib/ai-provider.ts
| "MiniMax integration", | ||
| () => { | ||
| it("generates a response from MiniMax M2.7", async () => { | ||
| it("generates a response from MiniMax M3", async () => { |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Do not claim this test always exercises MiniMax M3.
Because MINIMAX_MODEL remains configurable and this test neither sets nor asserts it, an environment override can make the test run against another model. Either pin MINIMAX_MODEL to MiniMax-M3 for this test with proper cleanup, or use a model-neutral title.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@__tests__/ai-provider.integration.test.ts` at line 13, Update the test named
“generates a response from MiniMax M3” so its behavior matches the title: pin
MINIMAX_MODEL to MiniMax-M3 for the test and restore the prior environment value
during cleanup, or rename the test to be model-neutral if it intentionally
supports configurable models.
Reason: The MiniMax provider still defaulted to a superseded model and did not expose the current MiniMax-M3 model.
What changed
lib/ai-provider.ts: the MiniMax provider now defaults to the currentMiniMax-M3model instead of the previous one. TheMINIMAX_MODELenvironment variable still overrides the default, so the earlierMiniMax-M2.7model remains selectable.__tests__/ai-provider.test.ts: updated the two assertions that pinned the default MiniMax model so they expectMiniMax-M3.__tests__/ai-provider.integration.test.ts: updated the integration test title to referenceMiniMax-M3.The change follows the existing provider pattern: a single string default that can be overridden via
MINIMAX_MODEL. No endpoint, base URL, or request-shape changes were made.Checks
npm test— 79 passed, 4 skipped (live-key integration tests).npx eslint lib/ai-provider.ts __tests__/ai-provider.test.ts __tests__/ai-provider.integration.test.ts— 0 errors.Summary by CodeRabbit
New Features
Tests