[clientpython] fix(backend): no more cookies by default (#209)#210
Open
[clientpython] fix(backend): no more cookies by default (#209)#210
Conversation
83ecc59 to
7f6fb45
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #210 +/- ##
==========================================
+ Coverage 70.39% 70.41% +0.02%
==========================================
Files 58 58
Lines 2327 2329 +2
==========================================
+ Hits 1638 1640 +2
Misses 689 689
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ncarenton
approved these changes
Apr 21, 2026
jabesq
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
RequestsBackendto allow only the following domains:[]Testing Instructions
Related issues
Checklist
Further comments
Two technical suggestions for blocking cookies while keeping the shared Session object: either create a custom CookiePolicy that blocks everything or use the default one but have an empty list as the list of allowed domains.
The custom CookiePolicy seemed to have more potential side-effects + if we need to in the future we can turn the allowed_domains into a parameter that will configure the backend (while still having the empty list as default).
Screenshots
A new test was added to check the session's cookie policy, whether is was not at None (the default that would mean accepting all) but still a len(0) (so an empty set so accept nothing).
new test before fix
new test after fix