fix(bash): narrow command deny pattern to actual invocations#209
Open
kaka86mm wants to merge 1 commit into
Open
fix(bash): narrow command deny pattern to actual invocations#209kaka86mm wants to merge 1 commit into
kaka86mm wants to merge 1 commit into
Conversation
The previous regex matched the word anywhere in the command string, including inside quoted arguments passed to other commands (e.g. `git log -S "su-do"`, `grep su-do file.txt`). This caused read-only commands to be rejected. Change the pattern to only match when it appears at the start of a command or after a command separator (;, &&, ||, |). Commands that merely reference the string as an argument or search term are no longer blocked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The current regex
/\bsudo\b/inDENY_PATTERNSmatches the word "sudo" anywhere in the command string — including inside quoted arguments passed to other commands.This means purely informational commands like these are incorrectly blocked:
Fix
Change the pattern from:
/\bsudo\b/to:
/(?:^|[;&|]\s*)sudo\b/This only matches
sudowhen it appears:sudo ...); sudo ...,&& sudo ...,|| sudo ...,| sudo ...)Commands that merely reference the string as an argument or search term are no longer blocked.
Test Results
sudo apt install xxxsudo cp /a /becho foo && sudo rm barecho foo; sudo rm barcat foo | sudo tee bargit log -S "sudo"grep sudo file.txtecho "sudo is blocked"cat "file with sudo"vim sudo.txt