Skip to content

fix: Mac missing fullscreen#642

Open
anderson-oki wants to merge 1 commit into
OpenCloudGaming:devfrom
anderson-oki:fix/mac-fullscreen
Open

fix: Mac missing fullscreen#642
anderson-oki wants to merge 1 commit into
OpenCloudGaming:devfrom
anderson-oki:fix/mac-fullscreen

Conversation

@anderson-oki

@anderson-oki anderson-oki commented Jul 14, 2026

Copy link
Copy Markdown

Problem

On macOS, the green traffic light button shows + (zoom) instead of the fullscreen arrows. Users cannot enter native fullscreen from the window controls.

Root Cause

Commit 07e5472 (console mode launch toggle) added fullscreen: startFullscreen to the BrowserWindow constructor. When startFullscreen is false (the normal case), passing fullscreen: false explicitly interferes with macOS's native fullscreen behavior. In v0.5.1, the property was omitted entirely, which worked correctly.

Before After
image image

Summary by CodeRabbit

  • Bug Fixes
    • Improved application window startup behavior by applying fullscreen mode only when explicitly enabled.
    • Preserved standard window startup behavior when fullscreen mode is disabled.

@capy-ai

capy-ai Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Capy auto-review is paused for this organization because the usage-cycle auto-review limit has been reached. Increase the limit or turn it off in billing settings to resume automatic reviews.

@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown

Review Change Stack

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: f6ea9236-3cd0-46be-a11f-8905567fa6c2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

createMainWindow now omits Electron’s fullscreen option when startFullscreen is false and includes it only when startup fullscreen is enabled.

Changes

Main window creation

Layer / File(s) Summary
Conditional fullscreen option
opennow-stable/src/main/index.ts
The BrowserWindow options conditionally add fullscreen: true based on startFullscreen.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: zortos293, kief5555, zaloguj12, jayian1890

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: fixing macOS fullscreen behavior by removing the explicit false fullscreen option.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@zortos293 zortos293 changed the base branch from main to dev July 14, 2026 08:31
@anderson-oki

Copy link
Copy Markdown
Author

I rebased against dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant