fix: Mac missing fullscreen#642
Conversation
|
Capy auto-review is paused for this organization because the usage-cycle auto-review limit has been reached. Increase the limit or turn it off in billing settings to resume automatic reviews. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthrough
ChangesMain window creation
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1ca92ee to
2525d8a
Compare
2525d8a to
9a4fb23
Compare
|
I rebased against dev |
Problem
On macOS, the green traffic light button shows + (zoom) instead of the fullscreen arrows. Users cannot enter native fullscreen from the window controls.
Root Cause
Commit 07e5472 (console mode launch toggle) added fullscreen: startFullscreen to the BrowserWindow constructor. When startFullscreen is false (the normal case), passing fullscreen: false explicitly interferes with macOS's native fullscreen behavior. In v0.5.1, the property was omitted entirely, which worked correctly.
Summary by CodeRabbit