Skip to content

OpenConceptLab/ocl_issues#2505 | added config for use_lexical_variants#20

Merged
snyaggarwal merged 2 commits into
mainfrom
issues#2505
May 14, 2026
Merged

OpenConceptLab/ocl_issues#2505 | added config for use_lexical_variants#20
snyaggarwal merged 2 commits into
mainfrom
issues#2505

Conversation

@snyaggarwal
Copy link
Copy Markdown
Contributor

Linked Issue

Refs OpenConceptLab/ocl_issues#2505

@snyaggarwal snyaggarwal requested a review from paynejd May 13, 2026 09:21
Copy link
Copy Markdown
Member

@paynejd paynejd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the companion to oclapi2#868 — closes the loop on use_lexical_variants end to end (project persistence → checkbox → $match request). Reviewed together they now form a complete change.

The wiring is clean and minimal. Two small notes:

1. Cross-link missing in both PR bodies. Neither this PR's description nor oclapi2#868 mentions the sibling. Worth a one-line Companion: OpenConceptLab/oclapi2#868 in each so reviewers (and future archaeologists) see the pair.

2. "Use Lexical Variants" is opaque without context. Inline suggestion below — a short helper/description so even core users can tell what the checkbox does without digging through code.

Merge order doesn't matter: if this lands first, oclapi2 master ignores the unknown variants field; if oclapi2 lands first, oclmap master doesn't yet send it so default-disabled holds. No race.

Comment thread src/components/map-projects/AdvancedSettings.jsx Outdated
@snyaggarwal snyaggarwal merged commit 18ec552 into main May 14, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants