Skip to content

Ignore bare-metal in deny.toml#11

Merged
kurtjd merged 1 commit into
OpenDevicePartnership:mainfrom
kurtjd:ignore-bare-metal-deny
Apr 30, 2026
Merged

Ignore bare-metal in deny.toml#11
kurtjd merged 1 commit into
OpenDevicePartnership:mainfrom
kurtjd:ignore-bare-metal-deny

Conversation

@kurtjd

@kurtjd kurtjd commented Apr 30, 2026

Copy link
Copy Markdown
Member

See: OpenDevicePartnership/embedded-services#817
We are experiencing the same issue here.

@kurtjd kurtjd self-assigned this Apr 30, 2026
Copilot AI review requested due to automatic review settings April 30, 2026 20:27
@kurtjd kurtjd requested a review from a team as a code owner April 30, 2026 20:27
@github-project-automation github-project-automation Bot moved this to In progress in ODP Backlog Apr 30, 2026
@kurtjd kurtjd moved this from In progress to In review in ODP Backlog Apr 30, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new RustSec advisory ignore to keep cargo deny check advisories passing for this embedded firmware repo while upstream dependencies migrate off a deprecated crate.

Changes:

  • Ignore RUSTSEC-2026-0110 (bare-metal deprecation/archive) in deny.toml with an explanatory reason.

@jerrysxie jerrysxie removed this from ODP Backlog Apr 30, 2026
@github-project-automation github-project-automation Bot moved this to In progress in ODP v0.2 Apr 30, 2026
@kurtjd kurtjd merged commit 29d4fe9 into OpenDevicePartnership:main Apr 30, 2026
34 checks passed
@github-project-automation github-project-automation Bot moved this from In progress to Done in ODP v0.2 Apr 30, 2026
@kurtjd kurtjd deleted the ignore-bare-metal-deny branch April 30, 2026 21:30
dymk added a commit to dymk/odp-embedded-controller that referenced this pull request May 28, 2026
embedded-services PR OpenDevicePartnership#11 (currently dymk/odp-canonical-wire-and-odp-client
@ b00c3a7) deleted embedded_services::relay::mctp::impl_odp_mctp_relay_handler!
and replaced it with odp_client::impl_odp_relay_handler! in a new odp-client
crate. This commit migrates platform-common to the new path and re-pins all
embedded-services-sourced deps (direct and transitive) through Cargo [patch]
sections so this PR can ship to the personal fork before PR OpenDevicePartnership#11 merges
upstream.

Files:

- platform/platform-common/Cargo.toml: add odp-client direct dep
- platform/platform-common/src/lib.rs: swap macro path
  embedded_services::relay::mctp::impl_odp_mctp_relay_handler!
    -> odp_client::impl_odp_relay_handler!
  (macro grammar unchanged — argument list is identical)
- platform/{platform-common,dev-qemu,dev-imxrt,dev-npcx,dev-mcxa,dev-mec}/Cargo.toml:
  add identical [patch."https://github.com/OpenDevicePartnership/embedded-services"]
  block re-routing 14 embedded-services workspace crates to the dymk fork
  rev b00c3a7. REVERT THIS BLOCK once PR OpenDevicePartnership#11 merges to upstream.
- platform/*/Cargo.lock: updated to resolve from the dymk fork rev

Gates (all 5 CI-matrix platforms pass cargo clippy --locked + fmt --check;
dev-qemu also passes cargo build --locked for riscv32imac-unknown-none-elf):
- platform-common / dev-qemu / dev-imxrt / dev-npcx / dev-mcxa: clippy clean
- dev-qemu binary: 6.3 MB ELF produced

A pre-existing clippy::clone_on_copy finding in
platform-common/src/mock/battery.rs:35 is gated behind --all-features
--all-targets which is NOT part of CI scope (CI runs default-features
clippy per platform). Reproduces unchanged on origin/main; out of scope
for this PR.
dymk added a commit to dymk/odp-embedded-controller that referenced this pull request May 28, 2026
embedded-services PR OpenDevicePartnership#11 (currently dymk/odp-canonical-wire-and-odp-client
@ b00c3a7) deleted embedded_services::relay::mctp::impl_odp_mctp_relay_handler!
and replaced it with odp_client::impl_odp_relay_handler! in a new odp-client
crate. This commit migrates platform-common to the new path and re-pins all
embedded-services-sourced deps (direct and transitive) through Cargo [patch]
sections so this PR can ship to the personal fork before PR OpenDevicePartnership#11 merges
upstream.

Files:

- platform/platform-common/Cargo.toml: add odp-client direct dep
- platform/platform-common/src/lib.rs: swap macro path
  embedded_services::relay::mctp::impl_odp_mctp_relay_handler!
    -> odp_client::impl_odp_relay_handler!
  (macro grammar unchanged — argument list is identical)
- platform/{platform-common,dev-qemu,dev-imxrt,dev-npcx,dev-mcxa,dev-mec}/Cargo.toml:
  add identical [patch."https://github.com/OpenDevicePartnership/embedded-services"]
  block re-routing 14 embedded-services workspace crates to the dymk fork
  rev b00c3a7. REVERT THIS BLOCK once PR OpenDevicePartnership#11 merges to upstream.
- platform/*/Cargo.lock: updated to resolve from the dymk fork rev

Gates (all 5 CI-matrix platforms pass cargo clippy --locked + fmt --check;
dev-qemu also passes cargo build --locked for riscv32imac-unknown-none-elf):
- platform-common / dev-qemu / dev-imxrt / dev-npcx / dev-mcxa: clippy clean
- dev-qemu binary: 6.3 MB ELF produced

A pre-existing clippy::clone_on_copy finding in
platform-common/src/mock/battery.rs:35 is gated behind --all-features
--all-targets which is NOT part of CI scope (CI runs default-features
clippy per platform). Reproduces unchanged on origin/main; out of scope
for this PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants