Skip to content

chore: drop duplicated MPL-2.0 license from simulators - #345

Merged
luytan merged 1 commit into
OpenGamingCollective:mainfrom
scardracs:remove-license-from-simulators
Aug 25, 2026
Merged

chore: drop duplicated MPL-2.0 license from simulators#345
luytan merged 1 commit into
OpenGamingCollective:mainfrom
scardracs:remove-license-from-simulators

Conversation

@scardracs

Copy link
Copy Markdown
Contributor

Description

Simply removed a duplicated LICENSE that is already on the project root

Verification and testing:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My code follows the style guidelines of this project (cargo fmt --all -- --check)
  • My changes generate no new warnings (cargo clippy --all -- -D warnings/cargo check --all-targets)
  • New and existing unit tests pass locally with my changes (cargo test --all)
  • Cranky with 0 warning (cargo cranky)

@coderabbitai

coderabbitai Bot commented Aug 25, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 46143334-343a-4269-930f-96811c461654

📥 Commits

Reviewing files that changed from the base of the PR and between 9d53a53 and 4b00511.

📒 Files selected for processing (1)
  • simulators/LICENSE
💤 Files with no reviewable changes (1)
  • simulators/LICENSE

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (2)
  • GitHub Check: cargo build --workspace (Ubuntu / rustc 1.93)
  • GitHub Check: cargo audit (Debian 13 / rustc 1.93)

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Removed the simulator license file and its associated licensing terms.

Walkthrough

The pull request deletes simulators/LICENSE, including its Mozilla Public License 2.0 terms and related legal provisions.

Changes

Cohort / File(s) Summary
Simulator license removal
simulators/LICENSE
Removes the complete Mozilla Public License 2.0 document from the simulators directory.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 4b005

This localized change removes a duplicate license file while retaining the project-root license; no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely identifies the main change: removing the duplicated MPL-2.0 license from the simulators.
Description check ✅ Passed The description explains the change and includes completed verification checks. It omits the issue reference and the Tested Hardware & Environment section, but these omissions are non-critical for a l…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the change and includes completed verification checks. It omits the issue reference and the Tested Hardware & Environment section, but these omissions are non-critical for a license-file removal.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@luytan
luytan merged commit c1640ca into OpenGamingCollective:main Aug 25, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants