fix(datadog): use correct MCP authentication headers - #510
Conversation
Co-authored-by: openhands <openhands@all-hands.dev>
|
✅ Review complete. This review was performed through OpenHands Cloud Automation. You can log in and view the conversation here. |
all-hands-bot
left a comment
There was a problem hiding this comment.
🟢 Good taste — Elegant, correct fix for a genuine bug.
The Datadog MCP server expects HTTP request headers, not environment variable names. HTTP headers use hyphen-delimited names (RFC 7230 convention), making DD-API-KEY / DD-APPLICATION-KEY correct and the previous underscore variants (DD_API_KEY / DD_APPLICATION_KEY) wrong. The old values would have caused authentication failures for every user of the api connection option. The fix is minimal, touches all three affected files consistently (catalog JSON, TypeScript typedef comment, and the regression test), and the PR description includes end-to-end validation evidence.
[RISK ASSESSMENT]
- [Overall PR]
⚠️ Risk Assessment: 🟢 LOW
Single-line bug fix per file. The change corrects a clearly broken authentication header name — no API surface change, no logic change, no dependency change. Risk is as low as it gets.
VERDICT:
✅ Worth merging: Correct, minimal fix backed by test evidence.
KEY INSIGHT:
HTTP header keys use hyphens; the previous underscore naming silently mirrored environment variable conventions, causing Datadog MCP authentication to fail for every user of the api connection option.
This review was generated by an AI agent (OpenHands) on behalf of the user through OpenHands Automation. View conversation
Summary
DD-API-KEYandDD-APPLICATION-KEY) instead of environment-variable names.Validation
uv run pytest -q tests/test_catalogs.py tests/test_integration_catalog_in_sync.pyThis pull request was created by an AI agent (OpenHands) on behalf of the user.