Skip to content

fix(datadog): use correct MCP authentication headers - #510

Merged
neubig merged 1 commit into
mainfrom
fix/datadog-mcp-header-names
Aug 25, 2026
Merged

fix(datadog): use correct MCP authentication headers#510
neubig merged 1 commit into
mainfrom
fix/datadog-mcp-header-names

Conversation

@neubig

@neubig neubig commented Aug 24, 2026

Copy link
Copy Markdown
Member

Summary

  • Use Datadog MCP HTTP header names (DD-API-KEY and DD-APPLICATION-KEY) instead of environment-variable names.
  • Update the public TypeScript documentation and catalog regression test.

Validation

  • uv run pytest -q tests/test_catalogs.py tests/test_integration_catalog_in_sync.py
  • 30 tests passed.
  • Verified the corrected headers connect to the US5 endpoint and discover Datadog MCP tools through the OpenHands Software Agent SDK.

This pull request was created by an AI agent (OpenHands) on behalf of the user.

Co-authored-by: openhands <openhands@all-hands.dev>
@github-actions github-actions Bot added the type: fix A bug fix label Aug 24, 2026
@neubig
neubig requested a review from all-hands-bot August 24, 2026 19:48

all-hands-bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Review complete.

This review was performed through OpenHands Cloud Automation. You can log in and view the conversation here.

@all-hands-bot all-hands-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Good taste — Elegant, correct fix for a genuine bug.

The Datadog MCP server expects HTTP request headers, not environment variable names. HTTP headers use hyphen-delimited names (RFC 7230 convention), making DD-API-KEY / DD-APPLICATION-KEY correct and the previous underscore variants (DD_API_KEY / DD_APPLICATION_KEY) wrong. The old values would have caused authentication failures for every user of the api connection option. The fix is minimal, touches all three affected files consistently (catalog JSON, TypeScript typedef comment, and the regression test), and the PR description includes end-to-end validation evidence.

[RISK ASSESSMENT]

  • [Overall PR] ⚠️ Risk Assessment: 🟢 LOW
    Single-line bug fix per file. The change corrects a clearly broken authentication header name — no API surface change, no logic change, no dependency change. Risk is as low as it gets.

VERDICT:
Worth merging: Correct, minimal fix backed by test evidence.

KEY INSIGHT:
HTTP header keys use hyphens; the previous underscore naming silently mirrored environment variable conventions, causing Datadog MCP authentication to fail for every user of the api connection option.

This review was generated by an AI agent (OpenHands) on behalf of the user through OpenHands Automation. View conversation

@neubig
neubig merged commit 806dfe5 into main Aug 25, 2026
7 checks passed
@neubig
neubig deleted the fix/datadog-mcp-header-names branch August 25, 2026 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants