Skip to content

Include conversation trigger in observability metadata and tags #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
juanmichelini wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Include conversation trigger in observability metadata and tags #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions openhands/app_server/app_conversation/live_status_app_conversation_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1591,6 +1591,7 @@ def _build_observability_context(
conversation_id: UUID,
*,
agent_kind: str,
trigger: ConversationTrigger | None = None,
selected_repository: str | None = None,
selected_branch: str | None = None,
git_provider: ProviderType | None = None,
Expand All @@ -1608,6 +1609,9 @@ def _build_observability_context(
}
tags = ['app:openhands', f'agent_kind:{agent_kind}']

if trigger:
metadata['trigger'] = trigger.value
tags.append(f'trigger:{trigger.value}')
if selected_repository:
metadata['repo_name'] = selected_repository
tags.append(f'repo:{selected_repository}')
Expand Down Expand Up @@ -2163,6 +2167,7 @@ async def _build_start_conversation_request_for_user(
observability_metadata, observability_tags = self._build_observability_context(
conversation_id,
agent_kind='openhands',
trigger=trigger,
selected_repository=selected_repository,
selected_branch=selected_branch,
git_provider=git_provider,
Expand Down Expand Up @@ -2453,6 +2458,7 @@ async def _build_acp_start_conversation_request(
observability_metadata, observability_tags = self._build_observability_context(
conversation_id,
agent_kind='acp',
trigger=trigger,
selected_repository=selected_repository,
selected_branch=selected_branch,
git_provider=git_provider,
Expand Down
23 changes: 23 additions & 0 deletions tests/unit/app_server/test_live_status_app_conversation_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1151,6 +1151,29 @@ def test_build_observability_context_includes_repository(self):
assert 'branch:main' in tags
assert 'git_provider:github' in tags

def test_build_observability_context_includes_trigger(self):
conversation_id = uuid4()

metadata, tags = self.service._build_observability_context(
conversation_id,
agent_kind='openhands',
trigger=ConversationTrigger.AUTOMATION,
)

assert metadata['trigger'] == 'automation'
assert 'trigger:automation' in tags

def test_build_observability_context_omits_trigger_when_unset(self):
conversation_id = uuid4()

metadata, tags = self.service._build_observability_context(
conversation_id,
agent_kind='openhands',
)

assert 'trigger' not in metadata
assert not any(tag.startswith('trigger:') for tag in tags)

def test_app_conversation_start_request_accepts_observability_fields(self):
request = AppConversationStartRequest(
observability_span_name='mySpanName',
Expand Down