Relax ready-for-dev heading check to accept h2 headings - #4632
Merged
Conversation
The readiness parser split issue bodies on `###` (h3) headings only, so free-form issues using `##` (h2) headings were treated as missing their Desired Behavior / Acceptance Criteria sections. Match any heading level of two or more hashes so `##` and `###` are handled equivalently. Fixes #4631 Co-authored-by: openhands <openhands@all-hands.dev>
Contributor
Python API breakage checks — ✅ PASSEDResult: ✅ PASSED |
Contributor
REST API breakage checks (OpenAPI) — ✅ PASSEDResult: ✅ PASSED |
Collaborator
Author
|
👋 This PR needs a couple of things fixed before OpenHands can review it:
Push an update once this is addressed and this check re-runs automatically. This is an automated check - no AI was used to generate this comment. |
jpshackelford
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4631.
The
ready-for-devreadiness check (.github/scripts/check_issue_readiness.py) split issue bodies on###(h3) headings only. Free-form issues (and issues edited by agents) often use##(h2) headings, which caused the bot to report those sections as missing and strip the label — e.g. #4577.Changes
HEADING_REnow matches any markdown heading of two or more hashes (^#{2,}\s+), so##and###sections are treated equivalently. A bare#title is still deliberately excluded.Test plan
python -m pytest tests/cross/test_check_issue_readiness.pyThis PR was created by an AI agent (OpenHands) on behalf of the maintainers.
🐳 Agent Server images for this PR — GHCR package, pull/run commands, and all pushed tags (click to expand)
• GHCR package: https://github.com/OpenHands/agent-sdk/pkgs/container/agent-server
Variants & Base Images
eclipse-temurin:17-jdknikolaik/python-nodejs:python3.13-nodejs22-slimgolang:1.21-bookwormPull (multi-arch manifest)
# Each variant is a multi-arch manifest supporting both amd64 and arm64 docker pull ghcr.io/openhands/agent-server:b01f7b6-pythonRun
All tags pushed for this build
About Multi-Architecture Support
b01f7b6-python) is a multi-arch manifest supporting both amd64 and arm64b01f7b6-python-amd64) are also available if needed