fix(deps): bump cmov 0.5.3 -> 0.5.4 (GHSA-3rjw-m598-pq24)#157
Open
alphaqiu wants to merge 1 commit into
Open
Conversation
Resolves Dependabot alerts #2 and #3, which are the same vulnerability (GHSA-3rjw-m598-pq24 / CVE-2026-50185) reported once per lockfile: - #2: root Cargo.lock - #3: tools/okb-gen/Cargo.lock cmov's aarch64 Cmov/CmovEq inline asm assumed zero-extension of sub-register-width loads, but the high bits are undefined per the Rust reference, causing csel to pick the wrong branch after a narrowing cast. Fixed in cmov 0.5.4. Both workspaces resolved the same transitive chain to the vulnerable 0.5.3: oak-keyring -> keepass 0.12.9 -> digest 0.11.3 -> ctutils 0.4.2 -> cmov. Updated both independent Cargo.lock files. Verified: release build + full test suite pass on both workspaces.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves Dependabot alerts #2 and #3. These are the same vulnerability (GHSA-3rjw-m598-pq24 / CVE-2026-50185,
cmov< 0.5.4), each generated once per lockfile:Cargo.lock(root)oktools/okb-gen/Cargo.lockDependabot reports per
(lockfile, dependency), so one vuln in two lockfiles yields two alerts.Root cause
tools/okb-genis an independent Cargo workspace (itsCargo.tomldepends on oak-keyring viapath = "../..", but it's not a member of a root[workspace]). It therefore carries its ownCargo.lock.oak-keyring -> keepass 0.12.9 -> digest 0.11.3 -> ctutils 0.4.2 -> cmov 0.5.3The vulnerability
cmov's aarch64Cmov/CmovEqinline asm assumed zero-extension of sub-register-width loads, but the high bits are undefined per the Rust reference. After a narrowing cast,cselcan pick the wrong branch, so constant-time primitives return wrong results. Fixed incmov0.5.4.Impact: aarch64-specific.
release.ymlbuildsokforaarch64-apple-darwinandaarch64-unknown-linux-gnu, so alert #2 has real exposure; #3 (okb-gen) is a dev-only tool.Changes
Cargo.lock: cmov 0.5.3 -> 0.5.4tools/okb-gen/Cargo.lock: cmov 0.5.3 -> 0.5.4 (also re-syncs the stale oak-keyring path-dep preview.1 -> preview.2)Verification
cargo build --releaseon root workspace: OKcargo teston root: 2600 unit + integration/e2e/snapshot suites, 0 failurescargo build+cargo teston okb-gen: OKcargo tree -i cmovresolves to 0.5.4 in both workspacesFollow-up (not in this PR)
To prevent recurrence, consider merging
tools/okb-geninto a root[workspace](share a singleCargo.lock) so future transitive vulns produce one alert instead of two.Dependabot alerts #2 #3