Feature/add top clipping - #3887
Draft
phobos2390 wants to merge 25 commits into
Draft
Conversation
…n occlusion for normal interactions
phobos2390
marked this pull request as draft
August 1, 2026 15:20
Member
|
Sounds like a nice feature. Could you add a video of this in action? |
Contributor
Author
|
Comment on lines
+283
to
+284
| static const int16_t __default_max_clip_height = 0x280; | ||
| static int16_t __max_clip_height = __default_max_clip_height; |
Member
There was a problem hiding this comment.
Identifiers with double underscores are reserved for compiler internals. Please avoid them.
We have a coding convention for constants. Please use kDefaultMaxClipHeight here. You can also use constexpr for them.
Member
Contributor
Author
Member
|
Understandable. Would you like me to take over to implement the window, then? |
Contributor
Author
|
Yes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Added shortcut that increments and decrements the clip height. Anything above the max clip height is not rendered and ignored for collision detection.
Additional features in this vein could include clip height presets and also ghost placement at the clip height itself.