Skip to content

Feature/add top clipping - #3887

Draft
phobos2390 wants to merge 25 commits into
OpenLoco:masterfrom
phobos2390:feature/Add_Top_Clipping
Draft

Feature/add top clipping#3887
phobos2390 wants to merge 25 commits into
OpenLoco:masterfrom
phobos2390:feature/Add_Top_Clipping

Conversation

@phobos2390

Copy link
Copy Markdown
Contributor

Added shortcut that increments and decrements the clip height. Anything above the max clip height is not rendered and ignored for collision detection.

Additional features in this vein could include clip height presets and also ghost placement at the clip height itself.

@phobos2390
phobos2390 marked this pull request as draft August 1, 2026 15:20
@AaronVanGeffen

AaronVanGeffen commented Aug 1, 2026

Copy link
Copy Markdown
Member

Sounds like a nice feature. Could you add a video of this in action?

@phobos2390

Copy link
Copy Markdown
Contributor Author

Sounds like a nice feature. Could you add a video of this in action?

https://youtu.be/J2s2Q2lhEso?is=0IAKWI3UaFOzWvXz

Comment on lines +283 to +284
static const int16_t __default_max_clip_height = 0x280;
static int16_t __max_clip_height = __default_max_clip_height;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Identifiers with double underscores are reserved for compiler internals. Please avoid them.

We have a coding convention for constants. Please use kDefaultMaxClipHeight here. You can also use constexpr for them.

@AaronVanGeffen

Copy link
Copy Markdown
Member

Rather than just making this a shortcut-only function, I think we should add a GUI for this. This could be a fairly simple window. Here's a screenshot of what the equivalent window looks like in OpenRCT2, and how to access it:

Forest Frontiers 2026-08-02 14-47-13

Would you like to work on this? Let us know if you need any help.

@phobos2390

Copy link
Copy Markdown
Contributor Author

Rather than just making this a shortcut-only function, I think we should add a GUI for this. This could be a fairly simple window. Here's a screenshot of what the equivalent window looks like in OpenRCT2, and how to access it:
Forest Frontiers 2026-08-02 14-47-13

Would you like to work on this? Let us know if you need any help.

Since this is basically the OpenRCT2 implementation that was the inspiration I think that'd be the goal. I'm not certain if I can be the developer to implement that view at this time however

@AaronVanGeffen

Copy link
Copy Markdown
Member

Understandable. Would you like me to take over to implement the window, then?

@phobos2390

Copy link
Copy Markdown
Contributor Author

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants