CI: check OSMC-PL 1.8 license header in Julia src files#76
Open
SVAGEN26 wants to merge 2 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #76 +/- ##
==========================================
- Coverage 24.78% 21.40% -3.39%
==========================================
Files 28 44 +16
Lines 3430 21219 +17789
==========================================
+ Hits 850 4541 +3691
- Misses 2580 16678 +14098 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
@SVAGEN26 I think you missed committing one file |
Rebuilt on current master (the previous branch was based on a pre-dev-fix OMBackend, so master's src — including the new src/precompile.jl from OpenModelica#77 — was never brought to standard, and the license check failed on the merge). - .github/workflows/check-license.yml: runs check_julia_license.py on src per PR. - .CI/scripts/check_julia_license.py: the checker (Julia #= =# headers, OSMC-PL 1.8 + current year), plus julia-license-exceptions.txt. - .gitignore: negate /.CI/ (the `/.*` rule was silently excluding it). - Bring all 51 src/*.jl to the OSMC-PL 1.8 header (was a mix of missing and 1.2). src/CodeGeneration/mtkExternals.jl is excluded — vendored MIT ModelingToolkit code — and left untouched. Verified: check_julia_license.py --summary src -> PASSED (51 checked, 1 skipped). All modified .jl files still parse under Julia 1.12. Co-authored-by: JKRT <jtinnerholm@gmail.com> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
SVAGEN26
force-pushed
the
add-julia-license-check
branch
from
363c093 to
3f456ec
Compare
Co-authored-by: JKRT <jtinnerholm@gmail.com> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a CI check that every
.jlfile undersrc/carries the OSMC-PL 1.8 license header with an up-to-date copyright year. This mirrors OpenModelica'scheck_runtime_license.py, adapted for Julia#= ... =#block comments.What's included
.CI/scripts/check_julia_license.py— the checker. Supports--fix-license,--update-year,--summary, and a.CI/scripts/julia-license-exceptions.txtexclusion list with.gitignore-style (last-match-wins) semantics..github/workflows/check-license.yml— runspython3 .CI/scripts/check_julia_license.py --summary srcon every pull request.src/files up to the OSMC-PL 1.8 header so the check passes on this PR. The existing OSMC-PL 1.2 headers were upgraded to 1.8, andsrc/CodeGeneration/mtkExternals.jlis excluded (vendored ModelingToolkit code under the MIT "Expat" License — not OSMC-PL), via the exceptions list.Notes
The check only looks at
src/(not examples/tests). Headers are verified for presence of the OSMC-PL 1.8 text, the "This file is part of OpenModelica." mark, and a current copyright year.🤖 Generated with Claude Code