Fix: Hapus keyword duplikat pada directive object-src di pengaturan Content Security Policy (CSP)#1578
Merged
Conversation
|
🔄 AI PR Review sedang antri di server...
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue #1577
Deskripsi PR
PR ini memperbaiki issue pada console browser di environment production di mana terdapat error syntax pada header Content Security Policy (CSP):
The Content-Security-Policy directive 'object-src' contains the keyword 'none' alongside with other source expressions.Sebelumnya, pada file middleware
SecurityHeaders.php, directive di-set menjadiobject-src 'none' ".$localDomain.". Sesuai standar spesifikasi web, jika keyword'none'digunakan, ia harus berdiri sendiri dan tidak boleh digabungkan dengan source expression lainnya (seperti$localDomain). Penggabungan ini membuat browser mengabaikan aturan tersebut dan memunculkan pesan error.Perubahan yang dilakukan:
".$localDomain."dari directiveobject-srcdiapp/Http/Middleware/SecurityHeaders.php.object-srcsekarang murni menggunakan nilai'none'(yang merupakan best practice keamanan untuk memblokir embed/object eksternal seperti Flash atau Java Applets).Dampak Perubahan:
Cara Pengujian (Testing Instructions):
directive 'object-src' contains the keyword 'none'.