Fix versioneer build failure on Python 3.12+ - #11
Open
lampo808 wants to merge 1 commit into
Open
Conversation
The bundled versioneer.py used configparser.SafeConfigParser() and
ConfigParser.readfp(), both deprecated since Python 3.2 and removed in
Python 3.12. This made `pip install pycorrelate` fail at the
"getting requirements to build wheel" stage on Python 3.12+ with:
AttributeError: module 'configparser' has no attribute 'SafeConfigParser'
Replace them with the modern equivalents ConfigParser() and read_file(),
available on all supported Python 3 versions (3.2+), so the build works on
both older and newer interpreters without any behavior change.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
pip install pycorrelatefails on Python 3.12+ during the"Getting requirements to build wheel" stage:
The bundled
versioneer.pyuses two configparser APIs that weredeprecated since Python 3.2 and removed in Python 3.12:
configparser.SafeConfigParser()parser.readfp(...)Fix
Replace them with their modern equivalents, which have been available
since Python 3.2:
configparser.ConfigParser()parser.read_file(...)This is a behavior-preserving 1:1 substitution. It works on every
supported Python 3 version (3.2 -> 3.13) -- it fixes the build on 3.12+
without breaking older interpreters.
Verification
On Python 3.12,
pip wheel . --no-depsnow completes successfully,whereas before it errored out in the versioneer config step.