feat(friends): display common friends on users' pages - #1660
Open
mrcatman wants to merge 5 commits into
Open
Conversation
veselcraft
approved these changes
Jul 2, 2026
veselcraft
left a comment
veselcraft
left a comment
Member
There was a problem hiding this comment.
для первого пулл реквеста очень неплохо)
myslivets
approved these changes
Jul 4, 2026
| </div> | ||
| </div> | ||
| </div> | ||
| <br/> |
Collaborator
There was a problem hiding this comment.
Коммит супер, но "br" здесь тупо лишний)
В остальном всё круто
Member
|
да, lint бы пофиксить, и можно пушить |
Member
|
киря, пофикси линт. иначе мы принять не сможем))) |
crythoughts
approved these changes
Aug 13, 2026
crythoughts
left a comment
crythoughts
left a comment
Collaborator
There was a problem hiding this comment.
- нужен метод friends.getMutual
- предлагаю на странице друзей добавить ссылку типа друзья друзей, но только тех которых у текущего юзера в друзьях нет
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Штош, с первым коммитом меня. Обнаружил что нигде нет списка общих друзей и это прям неудобно