refactor(webgal): 将引擎特效纹理从 game/tex 迁移到 assets#945
Open
A-kirami wants to merge 1 commit intoOpenWebGAL:devfrom
Open
refactor(webgal): 将引擎特效纹理从 game/tex 迁移到 assets#945A-kirami wants to merge 1 commit intoOpenWebGAL:devfrom
A-kirami wants to merge 1 commit intoOpenWebGAL:devfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the cherry blossoms, rain, and snow performance scripts by replacing hardcoded relative texture paths with imported asset URLs. This allows the build system to manage asset resolution and hashing more effectively. I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景
当前 snow、rain、cherryBlossoms 三个 PIXI perform 使用的纹理文件放在
public/game/tex,构建后进入dist/game/tex。这类资源本质上是引擎内置纹理,不属于游戏项目资源。继续放在
game/目录下会混淆引擎文件和游戏文件的边界,也绕开了引擎自身的 assets 构建管线。本次修改
snow.png、rain.png、cherryBlossoms.webp从packages/webgal/public/game/tex迁移到packages/webgal/src/assets/texdist/assets./game/tex/*作为运行时加载路径影响范围
packages/webgal/src/Core/gameScripts/pixi/performs/snow.tspackages/webgal/src/Core/gameScripts/pixi/performs/rain.tspackages/webgal/src/Core/gameScripts/pixi/performs/cherryBlossoms.tspackages/webgal/src/assets/tex/*预期收益
src/assets -> dist/assets的构建方式game/命名空间验证
packages/webgal下执行yarn builddist/assetsdist/game/tex中的这三张引擎纹理风险与兼容性
game/tex/*来替换这三种内置特效纹理,这种覆盖方式将失效