Skip to content

Mark closed upstream GitHub issues in rewards feed - #59

Open
Utkarsh2726 wants to merge 1 commit into
Opire:mainfrom
Utkarsh2726:fix/closed-upstream-rewards
Open

Mark closed upstream GitHub issues in rewards feed#59
Utkarsh2726 wants to merge 1 commit into
Opire:mainfrom
Utkarsh2726:fix/closed-upstream-rewards

Conversation

@Utkarsh2726

Copy link
Copy Markdown

Closes #55

Summary

  • Adds a small GitHub issue-state reconciler for rewards loaded into the home feed.
  • Marks upstream GitHub issues as closed when the public GitHub API reports state: "closed".
  • Shows a Closed upstream badge on affected reward cards and disables the claim action in the reward detail panel.
  • Keeps pagination based on the raw backend response length so marking closed items does not prematurely stop infinite scroll.
  • Tolerates GitHub API failures by leaving the existing reward unchanged instead of breaking the feed.

Validation

  • node_modules\.bin\vitest.cmd run app\_utils\reconcileGithubIssueState.test.ts app\home\_components\ClaimRewardModal.test.tsx
  • node_modules\.bin\tsc.cmd --noEmit
  • node_modules\.bin\eslint.cmd app\_utils\reconcileGithubIssueState.ts app\_utils\reconcileGithubIssueState.test.ts app\_utils\getRewards.ts app\_core\_dtos\IssueListDTO.ts app\home\view.tsx app\home\_components\HomeRewardCard.tsx

Lint note: targeted lint has 0 errors and 2 pre-existing image warnings in HomeRewardCard.tsx. Whole-project lint is blocked by existing CRLF line-ending errors across many untouched files.

@Utkarsh2726
Utkarsh2726 marked this pull request as ready for review August 21, 2026 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Available rewards feed includes closed GitHub issues

1 participant